Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iZ8eA-0006l8-1n for pgsql-hackers@arkaria.postgresql.org; Mon, 25 Nov 2019 07:18:58 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1iZ8e8-00089L-MJ for pgsql-hackers@arkaria.postgresql.org; Mon, 25 Nov 2019 07:18:56 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iZ8e8-000899-DL for pgsql-hackers@lists.postgresql.org; Mon, 25 Nov 2019 07:18:56 +0000 Received: from wout4-smtp.messagingengine.com ([64.147.123.20]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iZ8e5-0007DB-Le for pgsql-hackers@lists.postgresql.org; Mon, 25 Nov 2019 07:18:56 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 7781361A; Mon, 25 Nov 2019 02:18:51 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Mon, 25 Nov 2019 02:18:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=wwxiiXfarK3FgZsCeHOQxQLOOzw FMSrgVvEYytA4XSc=; b=SKpP/Rokf+yeYtKCMRDGynEyBeZVVyZOLIqm9wyQOQp 7LdgperUDff5hHe6SWLExr8EYGuxnRsjc+2/3pr17qEagMYhSfRc8TK9bSjFM21u /G3QSaxXn0nUUM9ng+s2fhGCqWx6CTH7HFXKnkVvq6ruHR2N1MwE+SvVYsQyzlsr v+wsU3Afp0GBg3O53e34+iZ7l8uNbOS4kNLhb9eYQ6Cobyrol06PqSLPL4Q08QVv VmopI94mJMdBvQ5C0CEj5xW/u94KiKM8DVDBXmm2TXSMN5xD885OKKMnNWoqD+ya cTMdGRjv1K1Z8Wo/qoXzQL/tlWSQzYjyPRbId6GEYaw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=wwxiiX farK3FgZsCeHOQxQLOOzwFMSrgVvEYytA4XSc=; b=JVIUuMj0q2ONc1mcNU6aMy gDwSVwG2fBj/i40eLwS48snfmN6LHoIS5Xo/hbD5dyVFs7GtGllN5wWBMW/+nsJJ VFR6I09CYXYQ0lpsjmv44paimedGgvCp6ZdhgVbPzbASNF3Yhv/ubQ9L05VOvpRu 5Px3jQsNK48Q3hUHNtXxU70kPBH9/cTL05PuG0F6EBy69EFLaTXi2DVXLu0w1PZ2 4jlVHq9j4hzpbME1Yhv2vHgxBdUZVvKnrjLSk+HM3nIcBHBUKnmQoeP1K0AY3DII rSPww4CvCJdjGdQlyZIxdWG/RBXu64LW2o58bzqJ942orywABs2PCOt5+EzKQWsw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrudeitddggeehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne gfrhhlucfvnfffucdljedtmdenucfjughrpeffhffvuffkfhggtggujgesghdtreertddt vdenucfhrhhomhepofhitghhrggvlhcurfgrqhhuihgvrhcuoehmihgthhgrvghlsehprg hquhhivghrrdighiiiqeenucfkphepudduuddruddtvddrudektddrudekheenucfrrghr rghmpehmrghilhhfrhhomhepmhhitghhrggvlhesphgrqhhuihgvrhdrgiihiienucevlh hushhtvghrufhiiigvpedt X-ME-Proxy: Received: from paquier.xyz (ee0822lan1.rev.em-net.ne.jp [111.102.180.185]) by mail.messagingengine.com (Postfix) with ESMTPA id B535B80059; Mon, 25 Nov 2019 02:18:41 -0500 (EST) Date: Mon, 25 Nov 2019 16:18:33 +0900 From: Michael Paquier To: Mark Dilger Cc: Postgres hackers Subject: Re: Safeguards against incorrect fd flags for fsync() Message-ID: <20191125071833.GD99720@paquier.xyz> References: <20191009062640.GB21379@paquier.xyz> <82db297a-74f7-ca23-545b-3c531d692e4d@gmail.com> <20191125022858.GE37821@paquier.xyz> <107de5d3-6972-7566-04d1-4776b677b462@gmail.com> <724f2e0a-9fd5-6e8a-5188-0fad8eb91bf7@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="NtwzykIc2mflq5ck" Content-Disposition: inline In-Reply-To: <724f2e0a-9fd5-6e8a-5188-0fad8eb91bf7@gmail.com> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --NtwzykIc2mflq5ck Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Nov 24, 2019 at 08:18:38PM -0800, Mark Dilger wrote: > Ok, it passes all regression tests, and I played around with > intentionally breaking the code to open file descriptors in > the wrong mode. The assertion appears to work as intended. >=20 > I'd say this is ready for commit. Thanks for the review. I'll look at that pretty soon. -- Michael --NtwzykIc2mflq5ck Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAl3bgEkACgkQnvQgOdby QH1+iQ/9GodVdH8noOTjTNhMS/jC3qchDVgPh1stVf9OcwKhDE4D8BkjQFKxXltc OM0j6ybRWMx4bw26vEV9177uVdCtXvZuptR7xef3mRRtCZGrT+hrxV8DR2iRKwDa PxAK1EQUsW//cV1MGRK2ZX/krtpPrm8cDX296Tc8CvSHMjqYMXMYZGnYxSMls9Q4 K4vohUn4aOeGz7PquZLdgtaHlX4ZDSJFhrKuPCPH6liWAYZKFxoOiZVaSA6vEej/ HWZQ+jugEALyrZ8Wwfm77oX4zxepse/WjcYocv5D8+9WApwvfBPmdSj1Eyk5WMz4 VfW0MKUrHZIThEpj5d6xhZLxXbVxDc6AvpI8tToBp0qNIMRIwG01JywubfjHSgLf 6Dj1G7iCP1Dehx7r0hhwlfmlzNr+uDVqWird7IN7dLBHNe5rRYfIBDY1vN0eOyz6 XdO5CJadbDExW38TNr9GT1PPQmV7qb46Bavspf7YKA5jTj1gO7NISkbZ2c9oUK1B C+wrrJbHpfmgmakmaHLMQ35xbdnOe/h1Ncb1oBCOVeJH5/8zzI6czsphWUgiAMrs NuuApQllLbiNVWD6AjHJYYeww+z4/88K77F3gDgW0kotJGjp/YoP1nPIc545y1mf DA+8qv3Jz6QczCgFVdAxhwvWmC7hsVegZntTdB70UmfYJ4C1FWA= =QaYR -----END PGP SIGNATURE----- --NtwzykIc2mflq5ck--