Date: Mon, 25 Nov 2019 17:05:12 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Andres Freund <andres@anarazel.de>
Cc: Alexey Bashtanov <bashtanov@imap.cc>,
	Alvaro Herrera <alvherre@2ndquadrant.com>,
	Peter Eisentraut <peter.eisentraut@2ndquadrant.com>,
	PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: log bind parameter values on error
Message-ID: <20191125080512.GL99720@paquier.xyz>
References: <20190920174627.qmaditduxlrrzb5l@alap3.anarazel.de>
 <20190920195657.GA20546@alvherre.pgsql>
 <20190920203905.xkv5udsd5dxfs6tr@alap3.anarazel.de>
 <4e374af0-5a2b-73fa-3dfe-d180fcd2ee3e@imap.cc>
 <20191107234104.5vjj2nh3jdx3uvqo@alap3.anarazel.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="CgTrtGVSVGoxAIFj"
Content-Disposition: inline
In-Reply-To: <20191107234104.5vjj2nh3jdx3uvqo@alap3.anarazel.de>
Precedence: bulk


--CgTrtGVSVGoxAIFj
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Nov 07, 2019 at 03:41:04PM -0800, Andres Freund wrote:
> The way you do it you need to do it in numerous places, and I'm pretty
> sure you're missing some already. E.g. this will not work to log
> parameters for parametrized statements generated on the server side,
> e.g. for foreign key queries. I don't think that's the right direction
> to go. You can maybe argue that we don't need support for logging server
> side generated parameters in the initial version, but the approach
> should be compatible with adding that support.

This patch had a review from two committers, with no updates from the
author, so marked as returned with feedback.
--
Michael

--CgTrtGVSVGoxAIFj
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAl3bizgACgkQnvQgOdby
QH0CTRAAgJrOUIi5IWV8gKFvfBCLHgcfX5e55xWKj4aebbVJjavHEdmGA3zHFCQw
YrRqLsElD5do13rcX92IE2O/eLGGZpgwuKJvjrU29+IXovigOiAJbLZiY7JJtcw3
QO30aFuic04M2IWAks5JWMVLLGPTqYTvR0GNFdvaWS03dli64IUgD7Jv0Uxfl6DH
SCjtBYoGa+UAwTRInh15HrjTePYTbOUZC79VJvfpQGWT3bHD3zZ9CkTv3frjS284
b2MUXTw3VNnW7f7naawXwd3O5rDfTev8lrZ/qSlRXdLZ5YhgEbzWkgoOLTRGwO48
/5DZCT5cyXza0z8JkZxyAshzMqcQXUU474a5PTTbT3KuG/owndHLLUHT2fu3SUVw
ol0LzUsHhsS7qJ7j/oRWJpgZ8f/go+EXmmr242sLvlC8FmwQtFGuURlRxv/i35Rv
5EMofMP95LwvVa5v+ncQ3aMcqRwCfZlVLRFOKkc3Pmkk1sJ7FrFmGHtLLM9CmHL/
A8+3S0jPWr+dnWIYnR6YFANfr4SS390h9TvNjLZWpTXdazv9GYi3+GkiDdPNYG8X
dIKDlbTSCsXfOfRHk3B/qljeHcUBTFXHNSgKFa8IpAokoAmMBRtj3KC8jtfIrCK2
HBhTdY+zFpEXIfr75V08yFZ1VmXLfsShcsq/pgSxu9wkJd2yuLM=
=BTjn
-----END PGP SIGNATURE-----

--CgTrtGVSVGoxAIFj--