Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iZSZH-0004C8-3L for pgsql-hackers@arkaria.postgresql.org; Tue, 26 Nov 2019 04:35:16 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1iZSZF-0002uF-Io for pgsql-hackers@arkaria.postgresql.org; Tue, 26 Nov 2019 04:35:13 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iZSZD-0002u8-Pn for pgsql-hackers@lists.postgresql.org; Tue, 26 Nov 2019 04:35:13 +0000 Received: from out1-smtp.messagingengine.com ([66.111.4.25]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iZSZ9-00025X-90 for pgsql-hackers@lists.postgresql.org; Tue, 26 Nov 2019 04:35:11 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 0BCC9227C6; Mon, 25 Nov 2019 23:35:05 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Mon, 25 Nov 2019 23:35:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=7pJ3UdupzKnS2II/uGMEB/+fD3P KhCw8mkr7CxLjqfk=; b=KGCD/aZANuSgRo4TiUb9TOoDXBeGR8vfPoBKVeOr37W dzffsM69u2sDnwlK124TaH6KtQKyg9zKEa6OejhhT1CdMj6ehE65Spb50kKuWtD8 tZ7pr10Vv/HzxuInbJN9R+Lbl8krLFq4ATE0i4xJyIKl5+zbA+SD9wQmSMh/WUEX +W8sUHAWi1qqlJVt8Xvbv+czUg8gVecUohZQqgLE/BEfQbZvz1ms0akJCOJuOyJ5 eKZvMAw2KO/Ovfr6CAx1Ap5ssITG0zgadVepAMiVDFDoGyZI8SQUSnXkhi2i7+Cm IXtZOEhBX/pmk+sex/4VOqSoO9pg3veRuVhy6nsN8tg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=7pJ3Ud upzKnS2II/uGMEB/+fD3PKhCw8mkr7CxLjqfk=; b=C3evESmBaZFBXO+c5ezhl3 wc/aoOXGKF5kwzu5cawal0vbpeFKDG3ydGWfvM71st/kbcB3TkfHOb0/8EduZEC/ PSNbyDgh3K23ZzqmkjoVd4RDSzstVc+8xngthzCEEReQXudvzxiYQOUH0dpIWO7Y gySH1ocM0LaOoTFtZ9sM7zxyR0IaHOIdDrb3J8RTOt2X1ROBzH56CkK69GCZBhle 51H9Aj3abYHfEbNl4vdAx4XNGxDtpr+9ILAzXa/GRNMCcs7WommTVTamqP5cYlmC aHdIBEnH4ppSuGCxFDf08RF9BYzvWDotDBiQeTKWN1VJbswzsCTUuFuDmodryQqw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrudeivddgjeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne gfrhhlucfvnfffucdljedtmdenucfjughrpeffhffvuffkfhggtggujgesghdtreertddt vdenucfhrhhomhepofhitghhrggvlhcurfgrqhhuihgvrhcuoehmihgthhgrvghlsehprg hquhhivghrrdighiiiqeenucfkphepudduuddruddtvddrudektddrudekheenucfrrghr rghmpehmrghilhhfrhhomhepmhhitghhrggvlhesphgrqhhuihgvrhdrgiihiienucevlh hushhtvghrufhiiigvpedt X-ME-Proxy: Received: from paquier.xyz (ee0822lan1.rev.em-net.ne.jp [111.102.180.185]) by mail.messagingengine.com (Postfix) with ESMTPA id A5D363060057; Mon, 25 Nov 2019 23:35:03 -0500 (EST) Date: Tue, 26 Nov 2019 13:34:59 +0900 From: Michael Paquier To: Mark Dilger Cc: Postgres hackers Subject: Re: Safeguards against incorrect fd flags for fsync() Message-ID: <20191126043459.GA5435@paquier.xyz> References: <20191009062640.GB21379@paquier.xyz> <82db297a-74f7-ca23-545b-3c531d692e4d@gmail.com> <20191125022858.GE37821@paquier.xyz> <107de5d3-6972-7566-04d1-4776b677b462@gmail.com> <724f2e0a-9fd5-6e8a-5188-0fad8eb91bf7@gmail.com> <20191125071833.GD99720@paquier.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="J2SCkAp4GZ/dPZZf" Content-Disposition: inline In-Reply-To: <20191125071833.GD99720@paquier.xyz> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --J2SCkAp4GZ/dPZZf Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Nov 25, 2019 at 04:18:33PM +0900, Michael Paquier wrote: > Thanks for the review. I'll look at that pretty soon. Tweaked a bit the comment block added, and committed. Thanks Mark for the input! -- Michael --J2SCkAp4GZ/dPZZf Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAl3cq3MACgkQnvQgOdby QH3ZQQ//RJ25Jxc21lJxMrli4Q160RjJyCGxtSWSt9NU23knFJKM8cjVgiev53AU rsIzLTdO1ZzToxw6wmBCK0wY/CM9pa9BK+hG5ioyLGdj79THGbzX5078c7gJ62kn oPpzCD+xaMMvlJTiVk1ubG6E98FqhoUFlcWQt13TadImRjV5MtMeEa0meTsxL2aY JAXnXQRtuNyezGPuItQd5v3TtngfWQbEdiYtbhQnkV7fEEUgw80QUFJgACIzSCaw W3T13oYyj/t5JRkPombBol1crEvQnZDQBGahNCyDriZuzESDoXDYNX3+DmMhfKkd Xg7/hPQ/MJp+jPXi0TG8VobXG+nQTg2fOQHmbqyjUXz9fAANJKkMj2A/8bDI+w6U 3SvpqiKeKoFtuLDcNox+v0yr/xuOIEUsGSVIgfblJXM8b9Y3nqeQnjjvX+o8LLFU B3ZhgrKHXBBSs4dVgHp6glcWsl5gpRAeYaRpUtg+ZVVH64Iyi7SufpNBYFXi4TAs +wHz4PlMt2jb8sWNdXfXpbRqguswb05L2N0B+Cp7EyV5Dp3fflRy3DDkfLsUpwnx E189poklNX/XflhTnLmF4gLEQjzC1+Wtxt27Snjbx50oaQYwl4IO+hXlZXxZ+Pjm LJ8bIXbOznwTW3kBoCEnR5Y9TW9kCcb9QUoJXVDqBlHtREmB4WQ= =8Ewq -----END PGP SIGNATURE----- --J2SCkAp4GZ/dPZZf--