Date: Wed, 27 Nov 2019 00:00:14 -0300
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Amit Langote <amitlangote09@gmail.com>
Cc: Tatsuro Yamada <tatsuro.yamada.tf@nttcom.co.jp>,
	vignesh C <vignesh21@gmail.com>,
	Pg Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: progress report for ANALYZE
Message-ID: <20191127030014.GD4161@alvherre.pgsql>
References: <d942639d-f54b-d58a-2dce-50bee22509cf@nttcom.co.jp_1>
 <20191126122251.GA2848@alvherre.pgsql>
 <CA+HiwqH_CxrSLwrNP=gWbbZUN9aQuv4+9qGgEPmacPWyLfmwiQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: 
 <CA+HiwqH_CxrSLwrNP=gWbbZUN9aQuv4+9qGgEPmacPWyLfmwiQ@mail.gmail.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

On 2019-Nov-27, Amit Langote wrote:

> On Tue, Nov 26, 2019 at 9:22 PM Alvaro Herrera <alvherre@2ndquadrant.com> wrote:
> >
> > On 2019-Nov-26, Tatsuro Yamada wrote:
> >
> > > > I wonder whether we need the total number of ext stats on
> > > > pg_stat_progress_analyze or not. As you might know, there is the same
> > > > counter on pg_stat_progress_vacuum and pg_stat_progress_cluster.
> > > > For example, index_vacuum_count and index_rebuild_count.
> > >
> > > Would it be better to add the total number column to these views? :)
> >
> > Yeah, I think it would be good to add that.
> 
> Hmm, does it take that long to calculate ext stats on one column?  The
> reason it's worthwhile to have index_vacuum_count,
> index_rebuild_count, etc. is because it can take very long for one
> index to get vacuumed/rebuilt.

Yes, it's noticeable.  It's not as long as building an index, of course,
but it's a long enough fraction of the total analyze time that it should
be reported.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services