Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iZogK-0007qL-OH for pgsql-hackers@arkaria.postgresql.org; Wed, 27 Nov 2019 04:12:01 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1iZogI-0007Ky-Bc for pgsql-hackers@arkaria.postgresql.org; Wed, 27 Nov 2019 04:11:58 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iZogH-0007Kr-Rq for pgsql-hackers@lists.postgresql.org; Wed, 27 Nov 2019 04:11:58 +0000 Received: from mail-qv1-xf30.google.com ([2607:f8b0:4864:20::f30]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iZogE-0006L3-Ir for pgsql-hackers@postgresql.org; Wed, 27 Nov 2019 04:11:57 +0000 Received: by mail-qv1-xf30.google.com with SMTP id o18so1071994qvf.1 for ; Tue, 26 Nov 2019 20:11:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=2ndquadrant-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=/fRGeRxYL1NIV90ZguV6bihZB34yCpZ7enf5MKEz0E8=; b=Te2p5uLjxlYcDAWT6fFznlBZirtzhQHFpV2BihPQaO9+a9ZU7c/ypSI5MBHlrQmlRX pWRaH76K487DlgKqAd6B3rzaOK0RsCcpedDgi+ktCpLyXNjAzg2IXd4RsX/zZ/SOcu+I qscxno1vBR7vCG6K6j41fccaVHJX9JE+0L6pG8VmIi57eK8cSmZHDOhG46aUBXRv4eeX Tt4TdwpI5EUSvJCs9NQSlqe6sXWIe3GQgGaxZr2G5NMlRt4JFHSZw36L2/iEkMP3sy0g bIa48t+guu/FztbC0niCr9wyC9ObuktPTMCFDE4ih0JcE08+c5C/TBbVQwJVn/Yd104q BWIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=/fRGeRxYL1NIV90ZguV6bihZB34yCpZ7enf5MKEz0E8=; b=kMQfmXcRLTABxx6eQhNykxYB/2JK814C56bQGexPplSd0thYHLxKcq8+7g6WSCs7d9 cBFakwmOt0lkgWqjCIxJ9wxT7VTmVMJzVUB21+LC/5z7y2LZD2aRas3R/C8xDQOHEsHZ sGHp6FD2fxFwowbif9vgFOqTy65pCmLBeM5MynfNrXsC1yuWRlQGdkNbGLq3H2Xpg96d 83w176/liFjo2eGnGwpiJ5RgLgIVM+oXvJb6UPt8KdfkQsBihbagPfi4aWXgIibQJFKo 9cklHEuGsflyjNVfzdSAcsKN0w2mrk4xbyfsecH6yqqjXwFZEKcS4aC4uiwD63R/7GdQ kGYA== X-Gm-Message-State: APjAAAUz/0a60mhw/AWsOtUziVFk/27vTLh/7NccqxaDEVcol57LrI5F QEkEzB7N+on5qenh4S8u7Ofj1g== X-Google-Smtp-Source: APXvYqy+Znw8JYqVNcw880rYZ6IpkYbL/SzD/9qSumiuN31Ete1uQzj/FKZSDqD+U7yJym/aSaP8IA== X-Received: by 2002:a0c:ac4b:: with SMTP id m11mr2714812qvb.235.1574827911915; Tue, 26 Nov 2019 20:11:51 -0800 (PST) Received: from nimloth.alvh.no-ip.org ([190.95.19.128]) by smtp.gmail.com with ESMTPSA id n5sm6102576qkf.48.2019.11.26.20.11.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Nov 2019 20:11:51 -0800 (PST) Received: by nimloth.alvh.no-ip.org (Postfix, from userid 1000) id 2DA45300A42; Wed, 27 Nov 2019 01:11:40 -0300 (-03) Date: Wed, 27 Nov 2019 01:11:40 -0300 From: Alvaro Herrera To: Kyotaro Horiguchi Cc: hlinnaka@iki.fi, andres@anarazel.de, pgsql-hackers@postgresql.org Subject: Re: Remove page-read callback from XLogReaderState. Message-ID: <20191127041140.GE4161@alvherre.pgsql> References: <20190925.155032.13779064.horikyota.ntt@gmail.com> <20190927.120726.16966854.horikyota.ntt@gmail.com> <20191024.145101.919376939160819394.horikyota.ntt@gmail.com> <20191127.120923.1004257038575385771.horikyota.ntt@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20191127.120923.1004257038575385771.horikyota.ntt@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 2019-Nov-27, Kyotaro Horiguchi wrote: > At Thu, 24 Oct 2019 14:51:01 +0900 (JST), Kyotaro Horiguchi wrote in > > Rebased. > > 0dc8ead463 hit this. Rebased. Please review the pg_waldump.c hunks in 0001; they revert recent changes. -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services