Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1ia2GT-0001O6-Cs for pgsql-hackers@arkaria.postgresql.org; Wed, 27 Nov 2019 18:42:13 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1ia2GR-0001y1-N7 for pgsql-hackers@arkaria.postgresql.org; Wed, 27 Nov 2019 18:42:11 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1ia2GR-0001xt-AN for pgsql-hackers@lists.postgresql.org; Wed, 27 Nov 2019 18:42:11 +0000 Received: from mail-qt1-x842.google.com ([2607:f8b0:4864:20::842]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1ia2GK-0007IN-9Y for pgsql-hackers@lists.postgresql.org; Wed, 27 Nov 2019 18:42:10 +0000 Received: by mail-qt1-x842.google.com with SMTP id i17so26393727qtq.1 for ; Wed, 27 Nov 2019 10:42:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=2ndquadrant-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=beRMBi4nTTYOdy6mmrqU5N4lPNwi6hJm3G54hlJBUAI=; b=v/sWH7RJNbXdiyLqyCnlBVDlIeKoRq7ZdBooGebuq9lAYAhcTzyUVCU4+6kJkonMJv Sw9Ps0UPi/LqgH9X4OsICKWVES4X88K14NNDAkrKH62jJ/QBo7rI/LpDLREziKPvulhl bnuA8nAPkV3EoVgrLzGD78qKagpVTkkOIdwG99RMjW3Th6bLhVL+Byky7Cvzo7+pbzsJ DpRgX0TktLI4gKtFENpCsF7HiWl48C0CAiqc0a5D/ScP8NE480ApSfe75NHMCWkHVukh w+1pzu6Nva1FqBFFPkS4cVN26G7utBsQLnaGUfXHmm/uvrTOq4TQqDgXMfSHdljtG9Zq /DQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=beRMBi4nTTYOdy6mmrqU5N4lPNwi6hJm3G54hlJBUAI=; b=Cg2AysEjPJ/FnfxOzfyP3p1boI/z/Jjx+49j6yzFwV9dGXw71T2AeUxhZDMjjVzxAG f4/dcE+fnXXClOWtvgBJ9CGy8hm+A9iKRAuDufFcsNauXcochQvFiw49L0WlZ3y7oJmb w+ASKfclMKkq8NDpFfBbQKbK25HIbkqdb7v4IcocCBj5Ecy+ohKjwoxiEEF2aw1wqTTW b9GNjtIAZLgtTmY59UDNNun3wH/rAJCNHhKO5w7KcdqSKy/oy/37mGGEWYWEz8e8eeYf M1mPuB5bgiN9Z5PSvf8FiMSUqhPT1MZ1D9ObbBAIBhE0X0X3f3lplMSNb8t7zCWEr5c7 TRNQ== X-Gm-Message-State: APjAAAXfkBjlLPnVkfbZWNCXl2FcdwBEoBYCZWt8R13WcE5w7wGPfqKd 9M7Vp0GKNlH9UGe3CiFsMSD36Q== X-Google-Smtp-Source: APXvYqxP6u4Pk3EpTwiAOmwS9DAUxl5QGozGBskGnWI4EyzvvGhSNv1eVooSl6DuHul8R3rQot4jEA== X-Received: by 2002:ac8:5308:: with SMTP id t8mr28906414qtn.51.1574880123011; Wed, 27 Nov 2019 10:42:03 -0800 (PST) Received: from nimloth.alvh.no-ip.org ([190.121.29.3]) by smtp.gmail.com with ESMTPSA id i17sm7949865qtm.53.2019.11.27.10.42.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Nov 2019 10:42:02 -0800 (PST) Received: by nimloth.alvh.no-ip.org (Postfix, from userid 1000) id B8651300661; Wed, 27 Nov 2019 15:41:59 -0300 (-03) Date: Wed, 27 Nov 2019 15:41:59 -0300 From: Alvaro Herrera To: Andrey Borodin Cc: Tomas Vondra , Michael Paquier , Peter Eisentraut , Gasper Zejn , pgsql-hackers@lists.postgresql.org Subject: Re: pglz performance Message-ID: <20191127184159.GA29849@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <8664A3B8-C049-45F5-9981-0E11BB619EE7@yandex-team.ru> User-Agent: Mutt/1.10.1 (2018-07-13) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 2019-Nov-27, Andrey Borodin wrote: > > > > 27 нояб. 2019 г., в 20:28, Tomas Vondra написал(а): > > > >>> > >>> 6) I'm pretty sure the comment in the 'while (off < len)' branch will be > >>> badly mangled by pgindent. > >> > >> I think I can just write it without line limit and then run pgindent. > >> Will try to do it this evening. Also, I will try to write more about > >> memmove. > Well, yes, I could not make pgindent format some parts of that > comment, gave up and left only simple text. Please don't. The way to avoid pgindent from messing with the comment is to surround it with dashes, /*--------- and end it with *------- */ Just make sure that you use well-aligned and lines shorter than 80, for cleanliness; but whatever you do, if you use the dashes then pgindent won't touch it. (I think the closing dash line is not necessary, but it looks better for things to be symmetrical.) -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services