Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iaa2K-0003a9-6F for pgsql-hackers@arkaria.postgresql.org; Fri, 29 Nov 2019 06:45:52 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1iaa2H-0005Yt-VJ for pgsql-hackers@arkaria.postgresql.org; Fri, 29 Nov 2019 06:45:49 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iaa2H-0005Ym-Ic for pgsql-hackers@lists.postgresql.org; Fri, 29 Nov 2019 06:45:49 +0000 Received: from sraihb2.sra.co.jp ([202.32.10.6]) by makus.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1iaa2E-0008P4-G8 for pgsql-hackers@postgresql.org; Fri, 29 Nov 2019 06:45:48 +0000 Received: from srascf.sra.co.jp (srascf [133.137.8.80]) by sraihb2.sra.co.jp (Postfix) with ESMTP id 80BA42A1647 for ; Fri, 29 Nov 2019 15:45:44 +0900 (JST) Received: from srascb.sra.co.jp (unknown [133.137.8.65]) by srascf.sra.co.jp with smtp id 6841_25fe_bde7c226_e101_4df8_abd8_ea871b0866f3; Fri, 29 Nov 2019 15:45:44 +0900 Received: from sranhm.sra.co.jp (osspc25 [133.137.174.97]) by srascb.sra.co.jp (Postfix) with ESMTP id 462652D6945 for ; Fri, 29 Nov 2019 15:45:44 +0900 (JST) Received: from yugon-CFSV7-1 (dhcp-175-183.sra.co.jp [133.137.175.183]) by sranhm.sra.co.jp (Postfix) with SMTP id 02DA3A1131; Fri, 29 Nov 2019 15:45:43 +0900 (JST) Date: Fri, 29 Nov 2019 15:45:13 +0900 From: Yugo Nagata To: nuko yokohama Cc: pgsql-hackers@postgresql.org, Tatsuo Ishii , hoshiai@sraoss.co.jp, alvherre@2ndquadrant.com, thomas.munro@gmail.com, kgrittn@gmail.com Subject: Re: Implementing Incremental View Maintenance Message-Id: <20191129154513.943f4ef05896d7b9d3fed69f@sraoss.co.jp> In-Reply-To: <20191126160225.a0e95389a0f83b9257080745@sraoss.co.jp> References: <20190912151950.GA933@alvherre.pgsql> <20190917.114913.2084517550718188623.t-ishii@sraoss.co.jp> <20190930223414.62e45861094e8ee68c2d0cbb@sraoss.co.jp> <20191122.152945.1693997586349309130.t-ishii@sraoss.co.jp> <20191126160225.a0e95389a0f83b9257080745@sraoss.co.jp> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk The following review on our patch was posted on another thread, so I quote here. The tab completion is Hoshiai-san's work, so he will handle this issue. Regards, Yugo Nagata. On Thu, 28 Nov 2019 13:00:05 +0900 nuko yokohama wrote: > Hi. > > I'm using the "Incremental Materialized View Maintenance" patch and have > reported the following issues. > (https://commitfest.postgresql.org/25/2138/) > > To Suggest a "DROP INCREMENTAL MATERIALIZED VIEW" in psql, but the syntax > error when you run. > ("DROP MATERIALIZED VIEW" command can drop Incremental Materialozed view > normally.) > > > ramendb=# CREATE INCREMENTAL MATERIALIZED VIEW pref_count AS SELECT pref, > COUNT(pref) FROM shops GROUP BY pref; > SELECT 48 > ramendb=# \d pref_count > Materialized view "public.pref_count" > Column | Type | Collation | Nullable | Default > ---------------+--------+-----------+----------+--------- > pref | text | | | > count | bigint | | | > __ivm_count__ | bigint | | | > > ramendb=# DROP IN > INCREMENTAL MATERIALIZED VIEW INDEX > ramendb=# DROP INCREMENTAL MATERIALIZED VIEW pref_count; > 2019-11-27 11:51:03.916 UTC [9759] ERROR: syntax error at or near > "INCREMENTAL" at character 6 > 2019-11-27 11:51:03.916 UTC [9759] STATEMENT: DROP INCREMENTAL > MATERIALIZED VIEW pref_count; > ERROR: syntax error at or near "INCREMENTAL" > LINE 1: DROP INCREMENTAL MATERIALIZED VIEW pref_count; > ^ > ramendb=# DROP MATERIALIZED VIEW pref_count ; > DROP MATERIALIZED VIEW > ramendb=# > > > Regard. -- Yugo Nagata -- Yugo Nagata