Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iciA6-0004CG-3a for pgsql-hackers@arkaria.postgresql.org; Thu, 05 Dec 2019 03:50:42 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1iciA2-0002fp-0W for pgsql-hackers@arkaria.postgresql.org; Thu, 05 Dec 2019 03:50:38 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iciA1-0002fI-Mx for pgsql-hackers@lists.postgresql.org; Thu, 05 Dec 2019 03:50:37 +0000 Received: from mx0a-00296801.pphosted.com ([148.163.150.38]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1ici9r-0006rx-SG for pgsql-hackers@postgresql.org; Thu, 05 Dec 2019 03:50:35 +0000 Received: from pps.filterd (m0114582.ppops.net [127.0.0.1]) by mx0a-00296801.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id xB53mBgC007005 for ; Thu, 5 Dec 2019 03:50:22 GMT Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) by mx0a-00296801.pphosted.com with ESMTP id 2wkf69m01v-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Thu, 05 Dec 2019 03:50:22 +0000 Received: by mail-pg1-f200.google.com with SMTP id v30so1020236pga.22 for ; Wed, 04 Dec 2019 19:50:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=3Hm4UWR3Q48PXhBcgQZngF2v6J/HhkHqoOQXKC9u5w4=; b=b7Uwp4Qcb/FTGHLLgLi9BzMSGGfm9O02d5cDTdIKtV8HEJYvWPNBTfcSx2zgFEvNEQ qmUiddLa52g7MXdNTcQ7HZZr62aJg5LYAYoN33nMOjZocvi/7fONmIzlDPpcqVE26wiB pGzTl1GDZtb/I2fbWMcyhCdzolb8XCIhCJiix5lb/PmphyBX8ajrBEa/4fzHHGXpj2EM ZdY4RC7VZHiD+yg9r0r0fUiSYwvRejAp5ua5rfm2Q2SIRB4owUF3SJeYvpN+Z4CDj2F/ u2WRE5v2x8U+TQcDSxR/NKbEd23TVtnq8yo2Keib7TaLAD2J2B1zzp7Z6fo5TSphVDrO LADQ== X-Gm-Message-State: APjAAAV5x9B7J18QbNRJnrTvKjfl9gx9zXawsirHgMDcXhLivcIc3v7S N++AHmVPpRcpW8cFWSo5tPGR2NJNsKHmucOp49yIZ0HFOP4abdnrXrUMPFhvC+9jHKC2+AHL3LZ 5V6mfj5jDKuCQfU+zt3sK3ACjW2wwDNnEV64pxFapewYXYPtzDg== X-Received: by 2002:a17:90a:21a1:: with SMTP id q30mr7140946pjc.8.1575517821585; Wed, 04 Dec 2019 19:50:21 -0800 (PST) X-Google-Smtp-Source: APXvYqz0MBn6cE9iAZVAtcaApBIaY2p2hB/8Wo6Pb+AnrpYPsby3MrXDa+/2+jveyp9a7ErtRN9hoA== X-Received: by 2002:a17:90a:21a1:: with SMTP id q30mr7140932pjc.8.1575517821419; Wed, 04 Dec 2019 19:50:21 -0800 (PST) Received: from localhost (li1619-9.members.linode.com. [172.104.39.9]) by smtp.gmail.com with ESMTPSA id q7sm9977843pfb.44.2019.12.04.19.50.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Dec 2019 19:50:20 -0800 (PST) Date: Wed, 4 Dec 2019 19:50:13 -0800 From: Adam Lee To: Jeff Davis Cc: Tomas Vondra , Taylor Vesely , Melanie Plageman , pgsql-hackers@postgresql.org Subject: Re: Memory-Bounded Hash Aggregation Message-ID: <20191205035013.GB1345@mars.local> References: <20190711155520.zqipi23o3yybx7ym@development> <9be86fc1adc315f69b8af4b379087ab451008d8a.camel@j-davis.com> <20190802064405.GA94036@mars.local> <617fea8258ba3df7bc8b21cd7f3afc219f2383d9.camel@j-davis.com> <20190802152123.ichmacgx3y3x7dc3@development> <20191128174644.snpuqldt5rndjru7@development> <2c8dc5c9178c391493dfbf6c2f595dc298dd477e.camel@j-davis.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2c8dc5c9178c391493dfbf6c2f595dc298dd477e.camel@j-davis.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.95,18.0.572 definitions=2019-12-04_04:2019-12-04,2019-12-04 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 mlxscore=0 malwarescore=0 suspectscore=1 impostorscore=0 bulkscore=0 clxscore=1011 lowpriorityscore=0 priorityscore=1501 phishscore=0 spamscore=0 mlxlogscore=573 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-1910280000 definitions=main-1912050025 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On Wed, Dec 04, 2019 at 06:55:43PM -0800, Jeff Davis wrote: > > Thanks very much for a great review! I've attached a new patch. Hi, About the `TODO: project needed attributes only` in your patch, when would the input tuple contain columns not needed? It seems like anything you can project has to be in the group or aggregates. -- Melanie Plageman & Adam