Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1ihvdF-0008Uv-1u for pgsql-hackers@arkaria.postgresql.org; Thu, 19 Dec 2019 13:14:21 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1ihvdC-0005O2-CO for pgsql-hackers@arkaria.postgresql.org; Thu, 19 Dec 2019 13:14:18 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1ihvdC-0005Nt-1G for pgsql-hackers@lists.postgresql.org; Thu, 19 Dec 2019 13:14:18 +0000 Received: from mail.dalibo.com ([212.85.157.172]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ihvd8-00049T-5m for pgsql-hackers@lists.postgresql.org; Thu, 19 Dec 2019 13:14:15 +0000 Received: from firost (unknown [88.190.0.6]) by mail.dalibo.com (Postfix) with ESMTPSA id 7CEF620345; Thu, 19 Dec 2019 14:14:11 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=dalibo.com; s=a; t=1576761251; bh=CeCWgi4zCh3PUQe4R9Qcuu6eq8xzG0/LlJht3Pw6Kdw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=D7aGafBbi77mguAhg8wax81OKOhUe73n/u9TQ/ciAfbjBph/NRsztejX1z1SYprLB FEZ4BP7xUyhoJWTTRpWALe3zO/zA05u/L6adtb5WIAgvcT31txZBopkgc78gdeacrk 9oz7fJoWlhJmR4VYvZHHRhEuiYlfFVGvfOKVcIn0= Date: Thu, 19 Dec 2019 14:14:10 +0100 From: Jehan-Guillaume de Rorthais To: Amit Kapila Cc: vignesh C , Peter Eisentraut , PostgreSQL Hackers Subject: Re: segmentation fault when cassert enabled Message-ID: <20191219141410.79745d26@firost> In-Reply-To: References: <20191025175929.7e90dbf5@firost> <18714.1572020918@sss.pgh.pa.us> <20191105172918.3e32a446@firost> <20191125155519.5338e3c9@firost> <32a64f45-6c01-d2bf-d90a-49ff4bfedcfb@2ndquadrant.com> <20191216164639.4b29efd4@firost> Organization: Dalibo MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On Wed, 18 Dec 2019 08:46:01 +0530 Amit Kapila wrote: > On Tue, Dec 17, 2019 at 6:01 PM vignesh C wrote: > > > > On Tue, Dec 17, 2019 at 10:09 AM Amit Kapila > > wrote: > > > > > > Attached patch with updated commit message based on suggestions. I am > > > planning to commit this tomorrow unless there are more comments. > > > > > > > While testing the patch on back versions, I found that the patch does > > not apply on PG 11 & PG 10 branch. Attached patch has the changes for > > PG 11 & PG 10 branch. Only difference in the patch was that table_open > > needed to be changed to heap_open. I have verified the patch on back > > branches and found it to be working. For PG 12 & current the previous > > patch that Amit need to be used, I'm not reattaching here. > > > > Pushed. Thanks!