Date: Tue, 31 Dec 2019 12:18:00 -0300
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Andreas Joseph Krogh <andreas@visena.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>,
	Peter Eisentraut <peter.eisentraut@2ndquadrant.com>,
	pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: color by default
Message-ID: <20191231151800.GA3531@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <VisenaEmail.2.330eb300c6573fe8.16f5c4b6415@tc7-visena>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

On 2019-Dec-31, Andreas Joseph Krogh wrote:

> It's easier to spot errors/warnings when they are colored/emphasized imo. Much 
> like colored output from grep/diff; We humans have colored vision for a reason. 

I do use color output (and find it useful), for that reason.

I'm not sure that the documentation addition properly describes the
logic to be used; if it does, I'm not sure that the logic is really what
we want.  Is the logic in the docs supposed to be "last rule that
matches wins" or "first rule that matches wins"?  I think that should be
explicit.  Do we want to have NO_COLORS override the TERM heuristics?
(I'm pretty sure we do.)  OTOH we also want PG_COLORS to override
NO_COLORS.

Per https://no-colors.org (thanks for the link) it seems pretty clear
that people who don't want colors should be already setting NO_COLORS,
and everyone would be happy.  It's not just PG programs that are
colorizing stuff.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services