Date: Sat, 4 Jan 2020 10:51:48 -0800
From: Noah Misch <noah@leadboat.com>
To: Amit Kapila <amit.kapila16@gmail.com>,
	Amit Khandekar <amitdkhan.pg@gmail.com>
Cc: Alvaro Herrera from 2ndQuadrant <alvherre@alvh.no-ip.org>,
	Andres Freund <andres@anarazel.de>,
	Juan =?iso-8859-1?Q?Jos=E9_Santamar=EDa?= Flecha
 <juanjo.santamaria@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
	Robert Haas <robertmhaas@gmail.com>,
	Thomas Munro <thomas.munro@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>,
	Tomas Vondra <tomas.vondra@2ndquadrant.com>
Subject: Re: logical decoding : exceeded maxAllocatedDescs for .spill files
Message-ID: <20200104185148.GA2270238@rfd.leadboat.com>
References: 
 <CAJ3gD9dnj=B=6cLZ-cDvPuYueZ10=D2Nfd+Ex5iP1TuRL7k20g@mail.gmail.com>
 <CAJ3gD9crCKe5oQVt2xQ21xRxb5dzsg+yioWkp8kHyiq6HfhjEQ@mail.gmail.com>
 <CAA4eK1+fogKCWvFzkEbSn5O7HQ-Xo+RKOtFf8=+tfqOzxd21dg@mail.gmail.com>
 <CAJ3gD9dV9SBCoMOJDZPDrB9-W74UpMvEeL+DBqg2Yg2BSmQstQ@mail.gmail.com>
 <CAA4eK1JdK+-uz_fXOo+p6no7jxvthjmxDkqyqC2bmKvHXiRUjw@mail.gmail.com>
 <CAJ3gD9edQpM6XkNGaaQ1eN9698-DOiQbF8UoseVXAQPwT0Se7A@mail.gmail.com>
 <CAA4eK1JSEn=UuTiYiAwqAWWEmLvMtnPMQ2+my0X8diEgtG6LqA@mail.gmail.com>
 <CAA4eK1LMDx6vK8Kdw8WUeW1MjToN2xVffL2kvtHvZg17=Y6QQg@mail.gmail.com>
 <CAA4eK1LJqMuXoCLuxkTr1HidbR8DkgRrVC7jHWDyXT=FD2gt6Q@mail.gmail.com>
 <CAJ3gD9dFYJnOxUsR3MeJ=3hJKZk5XqAx-6fYUNXt6jJOK3QFMQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: 
 <CAJ3gD9dFYJnOxUsR3MeJ=3hJKZk5XqAx-6fYUNXt6jJOK3QFMQ@mail.gmail.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Precedence: bulk

On Fri, Jan 03, 2020 at 02:20:09PM +0530, Amit Khandekar wrote:
> On Fri, 3 Jan 2020 at 10:19, Amit Kapila <amit.kapila16@gmail.com> wrote:
> > On Fri, Jan 3, 2020 at 8:29 AM Amit Kapila <amit.kapila16@gmail.com> wrote:
> >> I see one failure in REL_10_STABLE [1] which seems to be due to this commit:
> >
> > I tried this test on my CentOs and Power8 machine more than 50 times, but couldn't reproduce it.  So, adding Noah to see if he can try this test [1] on his machine (tern) and get stack track or some other information?
> >
> > [1] - make -C src/test/recovery/ check PROVE_TESTS=t/006_logical_decoding.pl
> 
> I also tested multiple times using PG 10 branch; also tried to inject
> an error so that PG_CATCH related code also gets covered, but
> unfortunately didn't get the crash on my machine. I guess, we will
> have to somehow get the stacktrace.

I have buildfarm member tern running this test in a loop.  In the 290
iterations so far, it hasn't failed.  I've leave it running for another week
or so.

The buildfarm client can capture stack traces, but it currently doesn't do so
for TAP test suites (search the client code for get_stack_trace).  If someone
feels like writing a fix for that, it would be a nice improvement.  Perhaps,
rather than having the client code know all the locations where core files
might appear, failed runs should walk the test directory tree for core files?