Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1isXCV-0006Hg-6U for pgsql-hackers@arkaria.postgresql.org; Fri, 17 Jan 2020 19:22:35 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1isXCR-00070A-WD for pgsql-hackers@arkaria.postgresql.org; Fri, 17 Jan 2020 19:22:31 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1isXCR-0006tt-J1 for pgsql-hackers@lists.postgresql.org; Fri, 17 Jan 2020 19:22:31 +0000 Received: from mail-qk1-x741.google.com ([2607:f8b0:4864:20::741]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1isXCJ-0001c4-Js for pgsql-hackers@postgresql.org; Fri, 17 Jan 2020 19:22:30 +0000 Received: by mail-qk1-x741.google.com with SMTP id d71so23825795qkc.0 for ; Fri, 17 Jan 2020 11:22:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=2ndquadrant-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=bil8wLUtCVgRYv5eqq1sm7vFh/bjvlZhE0gb6ng9amo=; b=m3gtOKUAe0lzQqgJO8boetaadLrfAxTO4UxYvwGdIo5OYgtsJYS/rlpYTrTg0u47TK gRA/+KQA2H6J4WeURFk/J1q6w1LvZB63OBXOlJVVIJo/ieAVMWKxtVaFcCKSIR+JkW5k 5n3F3MQ1OPVps328Y/WiALNigh9LeDGszW7MseqiC+3xlF/M900V3m7e0XhtTyvOAtOG 6x3I6Ar88Rzb77ACqgxIqIMlYl492qzbaQIop93vUFmkeGTSkAQjvlgobAgA69JzXc2G fwXXo3OPIO1e/vGwWmYvkLTw2ldpaqH/AVY7c+RGz3C/GYxU4pkpXg365yj4WP+TX+gw 0mGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=bil8wLUtCVgRYv5eqq1sm7vFh/bjvlZhE0gb6ng9amo=; b=e1pshFjOZpvZHSDOdsodxxd3RRptiz8VaxOADECmFNVYJG/Pc01r3dEjUWKZ/BVR0H BfQRDOuoTjMKHz02VxFzAKh9rI0qem+MF+611Px0FeXbPPC0OutuhW4O1rqV7RKi9Gke sywKMwHqtw8B8RGAqGQ13wKzXkjRjc7sookkYxNJTPQw7YzQiAzNW94ttj9S5Qw1mki2 3aYIU3WJ67Owgrm5mY4qnRWbVrpMnUo776adDrB+TdMwYTRGy6zzXBZDDCOnynlJ5/LO KIvSvvmzU58iNWRk1m+ziAIYi8zB7GLccUb7chNzfMIfSm5bLjHjKxtIzvqVzZel7iKu fkNQ== X-Gm-Message-State: APjAAAVydc/a1sc6jMSdT6Z4w0sEmLVIWv1ZJAiZTNdl7711329/GGRJ qH+uvhc6v29ha9ytGiEGl4jeSw== X-Google-Smtp-Source: APXvYqznWD2O15/TUu+r9LwVHj7viVdVeq+VV3UU8YJfKZAtH/BgcfaLHEtCzM1cVAi0fGhVW6nHvw== X-Received: by 2002:ae9:ebca:: with SMTP id b193mr39374159qkg.53.1579288940895; Fri, 17 Jan 2020 11:22:20 -0800 (PST) Received: from nimloth.alvh.no-ip.org ([179.56.30.174]) by smtp.gmail.com with ESMTPSA id i19sm11957877qki.124.2020.01.17.11.22.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jan 2020 11:22:20 -0800 (PST) Received: by nimloth.alvh.no-ip.org (Postfix, from userid 1000) id 5FB1E3009FE; Fri, 17 Jan 2020 16:22:18 -0300 (-03) Date: Fri, 17 Jan 2020 16:22:18 -0300 From: Alvaro Herrera To: Heikki Linnakangas Cc: Kyotaro Horiguchi , andres@anarazel.de, pgsql-hackers@postgresql.org Subject: Re: Remove page-read callback from XLogReaderState. Message-ID: <20200117192218.GA19889@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <5382a7a3-debe-be31-c860-cb810c08f366@iki.fi> User-Agent: Mutt/1.10.1 (2018-07-13) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 2020-Jan-17, Heikki Linnakangas wrote: > I changed that by adding new function, XLogBeginRead(), that repositions the > reader, and removed the 'lsn' argument from XLogReadRecord() altogether. All > callers except one in findLastCheckPoint() pg_rewind.c positioned the reader > once, and then just read sequentially from there, so I think that API is > more convenient. I like it. +1 -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services