Date: Sun, 19 Jan 2020 18:08:37 -0300
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Alexander Korotkov <a.korotkov@postgrespro.ru>,
	Alexey Kondratov <a.kondratov@postgrespro.ru>,
	Liudmila Mantrova <l.mantrova@postgrespro.ru>,
	Thomas Munro <thomas.munro@gmail.com>,
	Andrey Borodin <x4mmm@yandex-team.ru>,
	David Steele <david@pgmasters.net>,
	Andres Freund <andres@anarazel.de>,
	PostgreSQL-development <pgsql-hackers@postgresql.org>,
	Dmitry Dolgov <9erthalion6@gmail.com>, vladimirlesk@yandex-team.ru,
	dsarafan@yandex-team.ru
Subject: Re: [Patch] pg_rewind: options to use restore_command from
 recovery.conf or command line
Message-ID: <20200119210837.GA1485@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20200119102416.GB7464@paquier.xyz>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

On 2020-Jan-19, Michael Paquier wrote:

> So using WAL to tell about a WAL segment file is wrong, WALs is not a
> term that actually exists.

I agree.

> So, in my opinion, it is fine to use "WAL file", "WAL segment" or even
> "WAL segment file".

Agreed with these three terms -- "WAL file" seems to be the most common,
but the other two terms you suggest are just as good.

> +use File::Glob ':bsd_glob';
> +use File::Path qw(remove_tree make_path);
> +use File::Spec::Functions qw(catdir catfile);
> Is this compatible with our minimum perl requirements for the TAP
> tests?

By and large, we just join elements with a slash "foo/bar" to create
path names; no need for catdir or catfile, ISTM.

I *think* :bsd_glob should be available in all the Perl versions we
support, but I'm not sure that we really need it.  We seem to do just
fine with regular glob elsewhere.

PostgresNode already uses File::Path's rmtree.  Looking at its manual,
maybe the safest bet is to change all that to remove_tree.

Not sure about make_path.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services