Date: Mon, 20 Jan 2020 16:04:14 -0300
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Dean Rasheed <dean.a.rasheed@gmail.com>
Cc: Vik Fearing <vik.fearing@2ndquadrant.com>, Tom Lane <tgl@sss.pgh.pa.us>,
	Fabien COELHO <coelho@cri.ensmp.fr>,
	Stephen Frost <sfrost@snowman.net>,
	Chapman Flack <chap@anastigmatix.net>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Greatest Common Divisor
Message-ID: <20200120190414.GA32010@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: 
 <CAEZATCW282AQ0QwR-n+FSeyhyifvLZP9+p-iy_+8K-Nm1vCdNA@mail.gmail.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

On 2020-Jan-20, Dean Rasheed wrote:

> +       <entry>
> +        greatest common divisor &mdash; the largest positive number that
> +        divides both inputs with no remainder; returns <literal>0</literal> if
> +        both inputs are zero
> +       </entry>

Warning, severe TOC/bikeshedding ahead.

I don't know why, but this dash-semicolon sequence reads strange to me
and looks out of place.  I would use parens for the first phrase and
keep the semicolon, that is "greatest common divisor (the largest ...);
returns 0 if ..."

That seems more natural to me, and we're already using parens in other
description <entry>s.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services