Date: Tue, 21 Jan 2020 19:27:47 -0600
From: Justin Pryzby <pryzby@telsasoft.com>
To: Simon Riggs <simon@2ndquadrant.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: doc: alter table references bogus table-specific planner
 parameters
Message-ID: <20200122012747.GJ26045@telsasoft.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="5mjPmdht4ZehXHR2"
Content-Disposition: inline
User-Agent: Mutt/1.5.24 (2015-08-30)
Precedence: bulk


--5mjPmdht4ZehXHR2
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Jan 06, 2020 at 04:33:46AM +0000, Simon Riggs wrote:
> On Mon, 6 Jan 2020 at 04:13, Justin Pryzby <pryzby@telsasoft.com> wrote:
> > > I agree with the sentiment of the third doc change, but your patch removes
> > > the mention of n_distinct, which isn't appropriate.
> >
> > I think it's correct to remove n_distinct there, as it's documented previously,
> > since e5550d5f.  That's a per-attribute option (not storage) and can't be
> > specified there.
> 
> OK, then agreed.

Attached minimal patch with just this hunk.

https://commitfest.postgresql.org/27/2417/
=> RFC

Justin

(I'm resending in a new thread since it looks like the first message was
somehow sent as a reply to an unrelated thread.)

--5mjPmdht4ZehXHR2
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
 filename="v2-0001-doc-alter-table-references-bogus-table-specific-p.patch"

From 23873bbf32740b0f78f2102eb615e6a6aa615b8c Mon Sep 17 00:00:00 2001
From: Justin Pryzby <pryzbyj@telsasoft.com>
Date: Sun, 5 Jan 2020 19:39:29 -0600
Subject: [PATCH v2] [doc] alter table references bogus table-specific planner
 parameters

https://commitfest.postgresql.org/27/2417/
Fixes for commit 6f3a13ff
Should backpatch to v10.
---
 doc/src/sgml/ref/alter_table.sgml | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/doc/src/sgml/ref/alter_table.sgml b/doc/src/sgml/ref/alter_table.sgml
index bae6e6a..67eddfb 100644
--- a/doc/src/sgml/ref/alter_table.sgml
+++ b/doc/src/sgml/ref/alter_table.sgml
@@ -714,9 +714,7 @@ WITH ( MODULUS <replaceable class="parameter">numeric_literal</replaceable>, REM
      <para>
       <literal>SHARE UPDATE EXCLUSIVE</literal> lock will be taken for
       fillfactor, toast and autovacuum storage parameters, as well as the
-      following planner related parameters:
-      <varname>effective_io_concurrency</varname>, <varname>parallel_workers</varname>, <varname>seq_page_cost</varname>,
-      <varname>random_page_cost</varname>, <varname>n_distinct</varname> and <varname>n_distinct_inherited</varname>.
+      <varname>parallel_workers</varname> planner parameter.
      </para>
     </listitem>
    </varlistentry>
-- 
2.7.4


--5mjPmdht4ZehXHR2--