Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1ivigK-000617-Ju
	for pgsql-hackers@arkaria.postgresql.org; Sun, 26 Jan 2020 14:14:32 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1ivigJ-0002O0-G9
	for pgsql-hackers@arkaria.postgresql.org; Sun, 26 Jan 2020 14:14:31 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <pryzby@telsasoft.com>)
	id 1ivigJ-0002Nt-4b
	for pgsql-hackers@lists.postgresql.org; Sun, 26 Jan 2020 14:14:31 +0000
Received: from mail-yb1-xb31.google.com ([2607:f8b0:4864:20::b31])
	by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128)
	(Exim 4.92)
	(envelope-from <pryzby@telsasoft.com>)
	id 1ivigG-0003I7-Hr
	for pgsql-hackers@lists.postgresql.org; Sun, 26 Jan 2020 14:14:30 +0000
Received: by mail-yb1-xb31.google.com with SMTP id x18so3636319ybk.6
        for <pgsql-hackers@lists.postgresql.org>;
 Sun, 26 Jan 2020 06:14:28 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=telsasoft-com.20150623.gappssmtp.com; s=20150623;
        h=date:from:to:cc:subject:message-id:references:mime-version
         :content-disposition:in-reply-to:user-agent;
        bh=YD6e7ZbhxTmOhU3Hmd9dNL1XlUtxOGszvZpqsfqoWOI=;
        b=WgY2+NrUzQ6UBfFrRElaQavlbQTCrf2jEhfw4Jyv8lzMoQkqqTCkLQojXc1hkdCuZk
         J89Kh099E+0odMrD1a1LQ1x/G8YhlOacxysiwhsPYnGqYHL6aO2pL9t/vxj7bCLSMLGZ
         wUTzcnwoTdPmFtMK8MIHh1mUaGh7sdxG2ODYqefDbNR0/R4xeM9cYuae5lXZGknkoQRL
         as8WjBFc8J9ZbpJ+ewiPbGgbCPRz2O8dNSmpw3iZ7WBuIX5vXJPKT51jFM35DCGArMuh
         Xn3X8dr1PrqTo7pvGaU/vAuh8pTRryopYid3Pnf4Zg4P8pKYwsG3rAPY4DCHPvWCR5iP
         pPnw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:date:from:to:cc:subject:message-id:references
         :mime-version:content-disposition:in-reply-to:user-agent;
        bh=YD6e7ZbhxTmOhU3Hmd9dNL1XlUtxOGszvZpqsfqoWOI=;
        b=AVhfM6zADrsZAR2Sq7mbCpk7Kj2urMivoNxOufGDVj+8XzjC18iQ302ofpmPRoG+NW
         RtgaaQrWuZsBRYQFIJyeRSSQJSbc8nfn++Sn9Fx6Gykb1sB9WI82/TMAV9POruX9V/Gd
         FIrcb9ZTnuZj4lJm22IM0F5TrQG/odrOdMdSBU6nae+VHTFs7tJjc7IKAl4toLk89zxI
         NX05D7sH6YyXZdPrU8zqFgwo5jTDPz3+PRtWy0wcKPcNEK5k+FDNOEOGk1d3vo1whm9d
         aZH1MYeiwbhTb61exVAAcLQfi1HJK0y/n9Fi7YLtu2Z8hpv5l+4lKL0gVgOnz8ViDeXO
         2n9w==
X-Gm-Message-State: APjAAAU6hhigUgyLuvTDDQyiyVzFajUdUEckvUWeiS9EuIjHePmbrOJa
	vx9dJ4m3ky34iI4pvulol34STw==
X-Google-Smtp-Source: 
 APXvYqxUjPdd6yIj7XgKPTTU2gYFawN3fwVs2xRtpzF8fUdfkIV19anJBEqkPo6PSS+3kAL3LKC1fw==
X-Received: by 2002:a25:4d88:: with SMTP id
 a130mr8012238ybb.516.1580048067595;
        Sun, 26 Jan 2020 06:14:27 -0800 (PST)
Received: from pryzbyj (charmander.telsasoft.com. [50.244.222.1])
        by smtp.gmail.com with ESMTPSA id
 w200sm4719089ywa.34.2020.01.26.06.14.26
        (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
        Sun, 26 Jan 2020 06:14:26 -0800 (PST)
Received: by pryzbyj (Postfix, from userid 1000)
	id B3622800831; Sun, 26 Jan 2020 08:14:25 -0600 (CST)
Date: Sun, 26 Jan 2020 08:14:25 -0600
From: Justin Pryzby <pryzby@telsasoft.com>
To: pgsql-hackers@lists.postgresql.org
Cc: Jeff Janes <jeff.janes@gmail.com>
Subject: Re: explain HashAggregate to report bucket and memory stats
Message-ID: <20200126141425.GQ13621@telsasoft.com>
References: <20200103161925.GM12066@telsasoft.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200103161925.GM12066@telsasoft.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk

On Fri, Jan 03, 2020 at 10:19:25AM -0600, Justin Pryzby wrote:
> On Sun, Feb 17, 2019 at 11:29:56AM -0500, Jeff Janes wrote:
> https://www.postgresql.org/message-id/CAMkU%3D1zBJNVo2DGYBgLJqpu8fyjCE_ys%2Bmsr6pOEoiwA7y5jrA%40mail.gmail.com
> > What would I find very useful is [...] if the HashAggregate node under
> > "explain analyze" would report memory and bucket stats; and if the Aggregate
> > node would report...anything.
> 
> Find attached my WIP attempt to implement this.
> 
> Jeff: can you suggest what details Aggregate should show ?

Rebased on top of 10013684970453a0ddc86050bba813c611114321
And added https://commitfest.postgresql.org/27/2428/