Date: Mon, 3 Feb 2020 11:34:56 -0300
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Michael Paquier <michael@paquier.xyz>,
	Vik Fearing <vik.fearing@2ndquadrant.com>,
	Fabien COELHO <coelho@cri.ensmp.fr>,
	PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: Add %x to PROMPT1 and PROMPT2
Message-ID: <20200203143456.GA12688@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <5E008326-2335-4FB2-8513-D9018EC94F02@yesql.se>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

On 2020-Feb-03, Daniel Gustafsson wrote:

> > On 3 Feb 2020, at 08:08, Michael Paquier <michael@paquier.xyz> wrote:
> 
> > FWIW, I am not really in favor of changing a default old enough that
> > it could vote (a45195a).
> 
> That by itself doesn't seem a good reason to not change things.

Yeah.

> My concern would be that users who have never ever considered that the prompt
> can be changed, all of sudden wonder why the prompt is showing characters it
> normally isn't, thus causing confusion.  That being said, I agree that this is
> a better default long-term.

I think this is the good kind of surprise, not the bad kind.

I think the only kind of user that would be negatively affected would be
those that have scripted psql under expect(1) and would fail to read the
new prompt correctly.  But I would say that that kind of user is the one
most likely to be able to fix things as needed.  Everybody else is just
looking at an extra char in the screen, and they don't really care.

I'm +1 for the default change.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services