Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1izWgn-0006du-Ig for pgsql-hackers@arkaria.postgresql.org; Thu, 06 Feb 2020 02:14:46 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1izWgm-0004z6-Cr for pgsql-hackers@arkaria.postgresql.org; Thu, 06 Feb 2020 02:14:44 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1izWgl-0004yy-Tf for pgsql-hackers@lists.postgresql.org; Thu, 06 Feb 2020 02:14:44 +0000 Received: from mail-yw1-xc2c.google.com ([2607:f8b0:4864:20::c2c]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1izWgh-0005Yp-Ol for pgsql-hackers@postgresql.org; Thu, 06 Feb 2020 02:14:43 +0000 Received: by mail-yw1-xc2c.google.com with SMTP id 192so4451894ywy.0 for ; Wed, 05 Feb 2020 18:14:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telsasoft-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:subject:message-id:mime-version:content-disposition :user-agent; bh=t8NXKW0VTvLYKB0+1hcnVDoAkno/RKNreX6ILXjLdGY=; b=vq9ZYCa9MnBktNjjg5Hc+m5tYY+MmdCP5H5YMXZ0afVa5eGwnwRX3fXuPMExpDHs8v Xxr9WY8VIRMBffvRGDLwKlL889kiL0axwW8xRNKbNVB+Nm2hwRUjb+AcfFKueADRfDdb iCMyX+YKOHpFaczZZVPTBzSuh/vhE46s5XcpvGf4mli70E89Q/wuSAbgEYIiQzFhJhRe sOzPsRL1D6dd35EGvzsBpMf4fO5hYZoSqOYi6/+bsRBJhj00fAXuP8+5obcl8aTJIHyS 6SXG+Aa1QvhOfwEgL30WUNFB1PfoaPlVM4HrY+2YLR8dxmJd7O20feUcIg6HQdxJzq2m Ermw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:mime-version :content-disposition:user-agent; bh=t8NXKW0VTvLYKB0+1hcnVDoAkno/RKNreX6ILXjLdGY=; b=snO4sgp11FPltEZaHPm1Rd8awviKSJ9Oorx1k/D71s9zGFxWOstqbElNtotLAwoJFe FBS+A7l7JsykfjzyRNMOQA2wATMG5RLxY3hP9ZUBhy3C4A3CSGv/YhymFG6yiHhzt02m uQNsl7wkucvHqr1iHpEr9p61U95sx+fO6yrP3/aUZjCthChtPKv9qzQxd+viR4Ugzz85 I9s5dHgaXdksg7J3cLtla1yGPWJ/9tE1LztS5LKAKl9futT0XuyUUsnFPU8/HOcUdVbr gnaTRGDw2WLq8IyeF6ytqT/lYGi7fkiApI5BPjL48rM2BKP+j8jiQToX5CbM5bvaxihq TMgw== X-Gm-Message-State: APjAAAUu20WjCcGJVFJERafvs2Ia9W6Jz5PP+8yryp1KMjjl7hVrjXUw XuWLr7Yw/Fc3CuoXfc5nIQhr8bVPsPo= X-Google-Smtp-Source: APXvYqyZtwgSB098StavLQXvmgRkKhd989UN0vu1AJ8lG7x+BfMIqVaw6WJL68ag5qJOP5maZYenpw== X-Received: by 2002:a0d:cd84:: with SMTP id p126mr1094218ywd.319.1580955277286; Wed, 05 Feb 2020 18:14:37 -0800 (PST) Received: from pryzbyj (charmander.telsasoft.com. [50.244.222.1]) by smtp.gmail.com with ESMTPSA id k135sm839098ywe.2.2020.02.05.18.14.35 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 05 Feb 2020 18:14:36 -0800 (PST) Received: by pryzbyj (Postfix, from userid 1000) id 65DDB8007F7; Wed, 5 Feb 2020 20:14:32 -0600 (CST) Date: Wed, 5 Feb 2020 20:14:32 -0600 From: Justin Pryzby To: pgsql-hackers@postgresql.org Subject: typos in comments and user docs Message-ID: <20200206021432.GA24549@telsasoft.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="X1bOJ3K7DJ5YkBrT" Content-Disposition: inline User-Agent: Mutt/1.5.24 (2015-08-30) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --X1bOJ3K7DJ5YkBrT Content-Type: text/plain; charset=us-ascii Content-Disposition: inline I sent earlier version of this a few times last year along with bunch of other doc patches but it was never picked up. So maybe I'll try send one at a time in more digestible chunks. https://www.postgresql.org/message-id/flat/20190427025647.GD3925%40telsasoft.com#e1731c33455145eadc1158042cc411f9 From cb5842724330dfcfc914f2e3effdbfe4843be565 Mon Sep 17 00:00:00 2001 From: Justin Pryzby Date: Thu, 9 May 2019 21:13:55 -0500 Subject: [PATCH] spelling and typos --- doc/src/sgml/bloom.sgml | 2 +- doc/src/sgml/config.sgml | 2 +- doc/src/sgml/ref/alter_table.sgml | 2 +- doc/src/sgml/sources.sgml | 4 ++-- src/backend/access/transam/README.parallel | 2 +- src/backend/storage/buffer/bufmgr.c | 2 +- src/backend/storage/sync/sync.c | 2 +- src/include/access/tableam.h | 2 +- 8 files changed, 9 insertions(+), 9 deletions(-) diff --git a/doc/src/sgml/bloom.sgml b/doc/src/sgml/bloom.sgml index 6eeadde..c341b65 100644 --- a/doc/src/sgml/bloom.sgml +++ b/doc/src/sgml/bloom.sgml @@ -65,7 +65,7 @@ Number of bits generated for each index column. Each parameter's name refers to the number of the index column that it controls. The default - is 2 bits and maximum is 4095. Parameters for + is 2 bits and the maximum is 4095. Parameters for index columns not actually used are ignored. diff --git a/doc/src/sgml/config.sgml b/doc/src/sgml/config.sgml index b2c89bd..102698b 100644 --- a/doc/src/sgml/config.sgml +++ b/doc/src/sgml/config.sgml @@ -4318,7 +4318,7 @@ ANY num_sync ( numeric_literal, REM SET NOT NULL may only be applied to a column - providing none of the records in the table contain a + provided none of the records in the table contain a NULL value for the column. Ordinarily this is checked during the ALTER TABLE by scanning the entire table; however, if a valid CHECK constraint is diff --git a/doc/src/sgml/sources.sgml b/doc/src/sgml/sources.sgml index 5831ec4..b5d28e7 100644 --- a/doc/src/sgml/sources.sgml +++ b/doc/src/sgml/sources.sgml @@ -511,7 +511,7 @@ Hint: the addendum There are functions in the backend that will double-quote their own output - at need (for example, format_type_be()). Do not put + as needed (for example, format_type_be()). Do not put additional quotes around the output of such functions. @@ -880,7 +880,7 @@ BETTER: unrecognized node type: 42 practices. - Features from later revision of the C standard or compiler specific + Features from later revisions of the C standard or compiler specific features can be used, if a fallback is provided. diff --git a/src/backend/access/transam/README.parallel b/src/backend/access/transam/README.parallel index 85e5840..99c588d 100644 --- a/src/backend/access/transam/README.parallel +++ b/src/backend/access/transam/README.parallel @@ -169,7 +169,7 @@ differently because of them. Right now, we don't even allow that. At the end of a parallel operation, which can happen either because it completed successfully or because it was interrupted by an error, parallel workers associated with that operation exit. In the error case, transaction -abort processing in the parallel leader kills of any remaining workers, and +abort processing in the parallel leader kills off any remaining workers, and the parallel leader then waits for them to die. In the case of a successful parallel operation, the parallel leader does not send any signals, but must wait for workers to complete and exit of their own volition. In either diff --git a/src/backend/storage/buffer/bufmgr.c b/src/backend/storage/buffer/bufmgr.c index aba3960..5880054 100644 --- a/src/backend/storage/buffer/bufmgr.c +++ b/src/backend/storage/buffer/bufmgr.c @@ -4291,7 +4291,7 @@ ts_ckpt_progress_comparator(Datum a, Datum b, void *arg) * * *max_pending is a pointer instead of an immediate value, so the coalesce * limits can easily changed by the GUC mechanism, and so calling code does - * not have to check the current configuration. A value is 0 means that no + * not have to check the current configuration. A value of 0 means that no * writeback control will be performed. */ void diff --git a/src/backend/storage/sync/sync.c b/src/backend/storage/sync/sync.c index 9cb7c65..8282a47 100644 --- a/src/backend/storage/sync/sync.c +++ b/src/backend/storage/sync/sync.c @@ -216,7 +216,7 @@ SyncPostCheckpoint(void) /* * As in ProcessSyncRequests, we don't want to stop absorbing fsync - * requests for along time when there are many deletions to be done. + * requests for a long time when there are many deletions to be done. * We can safely call AbsorbSyncRequests() at this point in the loop * (note it might try to delete list entries). */ diff --git a/src/include/access/tableam.h b/src/include/access/tableam.h index 696451f..ba9f7b8 100644 --- a/src/include/access/tableam.h +++ b/src/include/access/tableam.h @@ -1185,7 +1185,7 @@ table_tuple_complete_speculative(Relation rel, TupleTableSlot *slot, * operation. That's often faster than calling table_insert() in a loop, * because e.g. the AM can reduce WAL logging and page locking overhead. * - * Except for taking `nslots` tuples as input, as an array of TupleTableSlots + * Except for taking `nslots` tuples as input, and an array of TupleTableSlots * in `slots`, the parameters for table_multi_insert() are the same as for * table_tuple_insert(). * -- 2.7.4 --X1bOJ3K7DJ5YkBrT Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0001-spelling-and-typos.patch" From cb5842724330dfcfc914f2e3effdbfe4843be565 Mon Sep 17 00:00:00 2001 From: Justin Pryzby Date: Thu, 9 May 2019 21:13:55 -0500 Subject: [PATCH] spelling and typos --- doc/src/sgml/bloom.sgml | 2 +- doc/src/sgml/config.sgml | 2 +- doc/src/sgml/ref/alter_table.sgml | 2 +- doc/src/sgml/sources.sgml | 4 ++-- src/backend/access/transam/README.parallel | 2 +- src/backend/storage/buffer/bufmgr.c | 2 +- src/backend/storage/sync/sync.c | 2 +- src/include/access/tableam.h | 2 +- 8 files changed, 9 insertions(+), 9 deletions(-) diff --git a/doc/src/sgml/bloom.sgml b/doc/src/sgml/bloom.sgml index 6eeadde..c341b65 100644 --- a/doc/src/sgml/bloom.sgml +++ b/doc/src/sgml/bloom.sgml @@ -65,7 +65,7 @@ Number of bits generated for each index column. Each parameter's name refers to the number of the index column that it controls. The default - is 2 bits and maximum is 4095. Parameters for + is 2 bits and the maximum is 4095. Parameters for index columns not actually used are ignored. diff --git a/doc/src/sgml/config.sgml b/doc/src/sgml/config.sgml index b2c89bd..102698b 100644 --- a/doc/src/sgml/config.sgml +++ b/doc/src/sgml/config.sgml @@ -4318,7 +4318,7 @@ ANY num_sync ( numeric_literal, REM SET NOT NULL may only be applied to a column - providing none of the records in the table contain a + provided none of the records in the table contain a NULL value for the column. Ordinarily this is checked during the ALTER TABLE by scanning the entire table; however, if a valid CHECK constraint is diff --git a/doc/src/sgml/sources.sgml b/doc/src/sgml/sources.sgml index 5831ec4..b5d28e7 100644 --- a/doc/src/sgml/sources.sgml +++ b/doc/src/sgml/sources.sgml @@ -511,7 +511,7 @@ Hint: the addendum There are functions in the backend that will double-quote their own output - at need (for example, format_type_be()). Do not put + as needed (for example, format_type_be()). Do not put additional quotes around the output of such functions. @@ -880,7 +880,7 @@ BETTER: unrecognized node type: 42 practices. - Features from later revision of the C standard or compiler specific + Features from later revisions of the C standard or compiler specific features can be used, if a fallback is provided. diff --git a/src/backend/access/transam/README.parallel b/src/backend/access/transam/README.parallel index 85e5840..99c588d 100644 --- a/src/backend/access/transam/README.parallel +++ b/src/backend/access/transam/README.parallel @@ -169,7 +169,7 @@ differently because of them. Right now, we don't even allow that. At the end of a parallel operation, which can happen either because it completed successfully or because it was interrupted by an error, parallel workers associated with that operation exit. In the error case, transaction -abort processing in the parallel leader kills of any remaining workers, and +abort processing in the parallel leader kills off any remaining workers, and the parallel leader then waits for them to die. In the case of a successful parallel operation, the parallel leader does not send any signals, but must wait for workers to complete and exit of their own volition. In either diff --git a/src/backend/storage/buffer/bufmgr.c b/src/backend/storage/buffer/bufmgr.c index aba3960..5880054 100644 --- a/src/backend/storage/buffer/bufmgr.c +++ b/src/backend/storage/buffer/bufmgr.c @@ -4291,7 +4291,7 @@ ts_ckpt_progress_comparator(Datum a, Datum b, void *arg) * * *max_pending is a pointer instead of an immediate value, so the coalesce * limits can easily changed by the GUC mechanism, and so calling code does - * not have to check the current configuration. A value is 0 means that no + * not have to check the current configuration. A value of 0 means that no * writeback control will be performed. */ void diff --git a/src/backend/storage/sync/sync.c b/src/backend/storage/sync/sync.c index 9cb7c65..8282a47 100644 --- a/src/backend/storage/sync/sync.c +++ b/src/backend/storage/sync/sync.c @@ -216,7 +216,7 @@ SyncPostCheckpoint(void) /* * As in ProcessSyncRequests, we don't want to stop absorbing fsync - * requests for along time when there are many deletions to be done. + * requests for a long time when there are many deletions to be done. * We can safely call AbsorbSyncRequests() at this point in the loop * (note it might try to delete list entries). */ diff --git a/src/include/access/tableam.h b/src/include/access/tableam.h index 696451f..ba9f7b8 100644 --- a/src/include/access/tableam.h +++ b/src/include/access/tableam.h @@ -1185,7 +1185,7 @@ table_tuple_complete_speculative(Relation rel, TupleTableSlot *slot, * operation. That's often faster than calling table_insert() in a loop, * because e.g. the AM can reduce WAL logging and page locking overhead. * - * Except for taking `nslots` tuples as input, as an array of TupleTableSlots + * Except for taking `nslots` tuples as input, and an array of TupleTableSlots * in `slots`, the parameters for table_multi_insert() are the same as for * table_tuple_insert(). * -- 2.7.4 --X1bOJ3K7DJ5YkBrT--