Date: Wed, 12 Feb 2020 14:28:19 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: client-side fsync() error handling
Message-ID: <20200212052819.GD1464@paquier.xyz>
References: <d239d1bd-aef0-ca7c-dc0a-da14bdcf0392@2ndquadrant.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="Ycz6tD7Th1CMF4v7"
Content-Disposition: inline
In-Reply-To: <d239d1bd-aef0-ca7c-dc0a-da14bdcf0392@2ndquadrant.com>
Precedence: bulk


--Ycz6tD7Th1CMF4v7
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Feb 11, 2020 at 09:22:54AM +0100, Peter Eisentraut wrote:
> Digging around through the call stack, I think changing fsync_fname() to
> just call exit(1) on errors instead of proceeding would address most of
> that.
>
> Thoughts?

Doing things as you do in your patch sounds fine to me for this part.
Now, don't we need to care about durable_rename() and make the
panic-like failure an optional choice?  From what I can see, this
routine is used now in the backend for pg_basebackup to rename
temporary history files or partial WAL segments.
--
Michael

--Ycz6tD7Th1CMF4v7
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAl5DjPMACgkQnvQgOdby
QH2FDBAAp2CFkK+CJUDRbo0tFyOEFUcv0UBlsP9SbZJch8huT8q7FjJWX8OtzEQI
BGx7Jm+ftasf1JydzaRwiAnquMqvlV50PWoGIRsxiw7Do9wU5hkjlLPgJYaNcPcV
rWTXAlvhe5UwdatrAiH2t+KKUjYxiHAJyjKkb+gslbv5Rf/KGpBrqQgfilaVCCL6
WQhCMN3WCd4vPeIPT1QZN8gbc5bs90KJ81zwYn1UwD5sIvL6OYs99RwkthUvp35C
d5NX+b6T8ESdQDzHnDizI6KScJUKRkoeDweTaO3SU2b04horpYWhffszpbwNqm53
zWSau1jQBg3eTFqw6inRtZK3vDBPy3+uYPzFffAgP6FTBkUMT3dySjWSWGRsJoZ9
6mzwAmHrEd0YA2PU6/k+JoXBEmz2wm7DFbifqODACai89ADyvkWgzJGbJFQbv44N
3uFQ29wccOodAoldQmtOD3PnJbCj8YjtY/Xr0otEmKbzElrkwgSVDbCydzcVipOi
F+DUfgNEYadNhGsSfk/vROpOf4/GgxboTfwwiKHpzWlQCzbcEl7uD4Ixx1sB++0F
k8Ksed6txv9T6SP61NHdC6yA92IZvZj/ow1D7MA7Py8aEjiJRrACeuYhnt643/A8
QOyCkt0pNb3C0ADioUYLlNDtcUP/dHtzOkniKdfqsWjbuhKpTKc=
=7qPI
-----END PGP SIGNATURE-----

--Ycz6tD7Th1CMF4v7--