Date: Thu, 13 Feb 2020 20:45:28 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Antonin Houska <ah@cybertec.at>
Cc: pgsql-hackers@postgresql.org
Subject: Re: Dead code in adminpack
Message-ID: <20200213114528.GL1520@paquier.xyz>
References: <32663.1581592539@antos>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="Z1OTrj3C7qypP14j"
Content-Disposition: inline
In-Reply-To: <32663.1581592539@antos>
Precedence: bulk


--Z1OTrj3C7qypP14j
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Feb 13, 2020 at 12:15:39PM +0100, Antonin Houska wrote:
> I've noticed that convert_and_check_filename() is always passed false for the
> "logAllowed" argument - someone probably forgot to remove the argument when it
> was decided that log files are no longer accepted. If the argument was removed,
> the function would become a bit simpler, see the patch.

This routine was originally named absClusterPath(), but even at its
origin point (fe59e56) this argument has never been used.  So no
objections to clean up that.
--
Michael

--Z1OTrj3C7qypP14j
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAl5FNtgACgkQnvQgOdby
QH0Ang/9FKDlaNhxg80bkNjCRClA8IzXhGjLdxFp/RkpWNT3CjA8caVH/HhGvaKr
/4o9nLaAogn4rW4yJHN0SSRXXzTAoGTM48Kx7IkJY/8dWRWeVJc0BiuRBtsKslug
jVSApH/XcHaKN1ZIi9QqkcVcQ6DWhUdZ2LFejU7fbhTwYBtTJFfrMqPKSG0siYBH
DC8CRhRAhGAPbjrBEc/uAzk4pBwM6V+6Smo7L+XMObr9MNlnC17MGxxoIzf3i7gF
SmbyRLHW6KvvepLPbcQsNMWtVJFZfX4qBaE5cFcQQKW0u3V7jGxnmJsF3q9GxkiQ
bthcm43c+y4rUdD1FclJ8Fj6ACLlcBtmpvYF/a/yn5JGhlCpdNThLy0c0KShpB++
QmeG85LgI2kFlBzd7vmAP6Z14dQqktiU3YclqVSFnZS2GwciJ3UzVIzcuPAYrUj0
HHl6sxv/4tfo6Q2crT0YNkn0+2DH1scxVlAxmYjxTsFwEv1r6Jlpzv4NwThTL4DQ
esL3ulb4mLynetMfBlxKk509S0KjtqE6OCrwWrbjELon6ArqskOWzw7cXSz/YfL7
sU1SEMxZHst1nJFlpbvIb79vyWeBblSs2cVAHt7hDKNoA95yoo/TQMs13PRF/3xp
xOGirGNznyi5gR4P5STf7t5LMB9ECGOlj8bHczbfD5c/vsjI5Xc=
=9Fgq
-----END PGP SIGNATURE-----

--Z1OTrj3C7qypP14j--