Date: Fri, 14 Feb 2020 12:44:03 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Julien Rouhaud <rjuju123@gmail.com>
Cc: Antonin Houska <ah@cybertec.at>,
	pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Dead code in adminpack
Message-ID: <20200214034403.GA1998@paquier.xyz>
References: <32663.1581592539@antos>
 <CAOBaU_Yp3euEyOV-nUOvtwjANYUypJN--RRoevDecRj6khWtNw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="SUOF0GtieIMvvwua"
Content-Disposition: inline
In-Reply-To: 
 <CAOBaU_Yp3euEyOV-nUOvtwjANYUypJN--RRoevDecRj6khWtNw@mail.gmail.com>
Precedence: bulk


--SUOF0GtieIMvvwua
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Feb 13, 2020 at 12:41:46PM +0100, Julien Rouhaud wrote:
> On Thu, Feb 13, 2020 at 12:14 PM Antonin Houska <ah@cybertec.at> wrote:
>> I've noticed that convert_and_check_filename() is always passed false fo=
r the
>> "logAllowed" argument - someone probably forgot to remove the argument w=
hen it
>> was decided that log files are no longer accepted. If the argument was r=
emoved,
>> the function would become a bit simpler, see the patch.
>=20
> Indeed, and actually I don't see when this codepath was reachable.
>=20
> Patch LGTM.

Thanks, applied.
--
Michael

--SUOF0GtieIMvvwua
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAl5GF4MACgkQnvQgOdby
QH0SAQ//V8qHbqFL4viSUFLKLRZ1BZXjrcjeNadcu3dGFLtklB3aRlvuhVMdPgYA
iLd8kKNNquQfVsc4bXDfp8Jsvb4eZVXUTFagtHP+/A6caW2DrySk6w8qYiFD47sr
RkeyvmAkad5nX15mkPXwcnCyb/hzxc1MtyEXMMHlcGmQ7haXtz/RbHGjca6ERadp
PpBCX3Q0H8p5EMeXGbjBnRVjnpCiGd4+pm2LJVaJVeoUETYKRvNoffWZZUilgfvg
pe198OE5pXY6f1oo8xY3N1izhPTPCZ6WMy0efPkM1jSRtrcLdHPE4l1u5zLHPiuN
9hjpOOwyM6Od/98xWAOCUGRNMZk0xAa3Hq8si31VUFTm2sv1ZxUU65ZtQXo4qn0i
eBcdVmmmkk2+c5bCwU9+GB4jDjn4Vgk36rR1zheKup4geSb+2FCmuYW1XURqZq8Q
oDlW9HnmzZH/MV/KQ8WJXENrypw+OgUK3nXE1pSDszMGB1K9dAaPd/W8Xo0X2tuq
a8n89pFsxYOcqx2UUuplZJaE5IcMdEMCvV3W7PFDckqyXptb0dX9GvvTFUeOPo//
eBe8dWkbjcQQ6/c46qXUFcw4ESl5BYqHC4DUjazNnIuaUjeYfUWBX/+tf1wxjqLi
pG3LDhwX8I8Dunp+ar16dG5BuXV+2+fRJBrq6gThNikFGxRfDms=
=B0o7
-----END PGP SIGNATURE-----

--SUOF0GtieIMvvwua--