Date: Fri, 14 Feb 2020 12:13:01 -0300
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Amit Langote <amitlangote09@gmail.com>
Cc: John Naylor <john.naylor@2ndquadrant.com>, Tom Lane <tgl@sss.pgh.pa.us>,
	Justin Pryzby <pryzby@telsasoft.com>,
	PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: assert pg_class.relnatts is consistent
Message-ID: <20200214151301.GA6618@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: 
 <CA+HiwqGnoqzr6kWfzS56FxhT49iZXZF_susVNHwUHoLrK=v8pw@mail.gmail.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

I propose this more concise coding for AddDefaultValues,

	# Now fill in defaults, and note any columns that remain undefined.
	foreach my $column (@$schema)
	{
		my $attname = $column->{name};
		my $atttype = $column->{type};

		# Skip if a value already exists
		next if defined $row->{$attname};

		# 'oid' and 'relnatts' are special cases. Ignore.
		next if $attname eq 'oid';
		next if $attname eq 'relnatts';

		# This column has a default value.  Fill it in.
		if (defined $column->{default})
		{
			$row->{$attname} = $column->{default};
			next;
		}

		# Failed to find a value.
		push @missing_fields, $attname;
	}

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services