Date: Tue, 18 Feb 2020 12:39:49 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Fujii Masao <masao.fujii@oss.nttdata.com>
Cc: Robert Haas <robertmhaas@gmail.com>,
	"pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Subject: Re: Wait event that should be reported while waiting for WAL
 archiving to finish
Message-ID: <20200218033949.GD4176@paquier.xyz>
References: <f0651f8c-9c96-9f29-0ff9-80414a15308a@oss.nttdata.com>
 <20200213032804.GB1520@paquier.xyz>
 <949931aa-4ed4-d867-a7b5-de9c02b2292b@oss.nttdata.com>
 <20200213073035.GI1520@paquier.xyz>
 <eb1287bd-64ee-07a5-057e-710d93e7f39e@oss.nttdata.com>
 <CA+Tgmoa3BVNJ+LVrytUrsK+MtxEogc_jurDgJ=rkMAEt06Hk6Q@mail.gmail.com>
 <61477660-dded-2550-b101-c76a2f864806@oss.nttdata.com>
 <20200217094857.GB115140@paquier.xyz>
 <d9d85efa-f62e-400e-2edf-9e1b8c0df651@oss.nttdata.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="A9z/3b/E4MkkD+7G"
Content-Disposition: inline
In-Reply-To: <d9d85efa-f62e-400e-2edf-9e1b8c0df651@oss.nttdata.com>
Precedence: bulk


--A9z/3b/E4MkkD+7G
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Feb 17, 2020 at 10:21:23PM +0900, Fujii Masao wrote:
> On 2020/02/17 18:48, Michael Paquier wrote:
>> Actually, I have some questions:
>> 1) Should a new wait event be added in recoveryPausesHere()?  That
>> would be IMO useful.
>=20
> Yes, it's useful, I think. But it's better to implement that
> as a separate patch.

No problem for me.

>> 2) Perhaps those two points should be replaced with WaitLatch(), where
>> we would use the new wait events introduced?
>=20
> For what? Maybe it should, but I'm not sure it's worth the trouble.

I don't have more to offer than signal handling consistency for both
without relying on pg_usleep()'s behavior depending on the platform,
and power consumption.  For the recovery pause, the second argument
may not be worth carrying, but we never had this argument for the
archiving wait, did we?  For both, on top of it you don't need to
worry about concurrent issues with the wait events attached around.
--
Michael

--A9z/3b/E4MkkD+7G
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAl5LXIUACgkQnvQgOdby
QH0JqA/+JZ6D6syCt9iFQTf7DpcPrE6O1F0uXaIUl6X8pVb1SUSBarju8VKHr1fd
EivxsWa8puJx5fg7oGStHFsH/7uiBUmQfeTfZ/fG0ScFNNpNSKPMJB1W5zLlOcYm
v+DrCsvhQCW5/hsaLVJ81Hp3o8zzqJPdf+h/Og1IRuKn5ekLw2Uqx0/46Qg7yR/b
7eUGGg3qzHT55IuNkvir6yXRRR2NHj1QikD77hIfzTmdA6amdPURG76/NVeGSFIw
YVjQveCXOnMnLdioGaIXh4yF7Bg6I7NXZpyTOH4FRZo2ve+Gt0h7Odh6jCVs2/Il
i2WDR/Kvn66wGG3B4h7X0cOtGkWwp49kM5yTvnUSsjNjEgRbJRRz6UJahYH2rBs8
fU4aIGTAPP9yBbx6+i61/jAIJLSFrCYup76sTr48f81of6wVBhZqiqygfoJh2Hnc
Kct1dP9wQfi8F7rTwkOhqkbXn/GSByYSGF2qj8Yc2/Sj6/eKn3z3n1sj0OLWMkLg
Wa+aOVD9HGbT3EV9YCDDrr5W8at/d9mOH3gf2sJO8qp/4wahzT0AP6jRpagfWXKu
rysnjakHAuQhDGdrVAntWhaJGvzRXXcGHC7Fv3TTHInOm6wbY4Ut/E0up1MDYicm
CP2luS1X7/Fn4dfHjbV4j9NqpCJvgTjkrOs+jKeEbkY2hO9NdlU=
=f96j
-----END PGP SIGNATURE-----

--A9z/3b/E4MkkD+7G--