Date: Thu, 27 Feb 2020 16:32:11 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Julien Rouhaud <rjuju123@gmail.com>
Cc: Justin Pryzby <pryzby@telsasoft.com>, Sergei Kornilov <sk@zsrv.org>,
	Peter Eisentraut <peter.eisentraut@2ndquadrant.com>,
	Michael Paquier <michael.paquier@gmail.com>,
	Andreas Karlsson <andreas@proxel.se>,
	pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: reindex concurrently and two toast indexes
Message-ID: <20200227073211.GA403330@paquier.xyz>
References: <20200216190835.GA21832@telsasoft.com>
 <20200218052933.GH4176@paquier.xyz>
 <CAOBaU_Z1-uD1nbnQwJXgSc2xYvPWe=Cn5vJwyAjOCd+tWfxt5w@mail.gmail.com>
 <20200218061913.GJ4176@paquier.xyz>
 <CAOBaU_bieK_PPD-NzBF1jR+QCNeJ75vZu_6hqCq_zbZHsDijgQ@mail.gmail.com>
 <20200222070924.GA57285@nol>
 <20200222150657.GA54846@nol>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="0F1p//8PRICkK4MW"
Content-Disposition: inline
In-Reply-To: <20200222150657.GA54846@nol>
Precedence: bulk


--0F1p//8PRICkK4MW
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Sat, Feb 22, 2020 at 04:06:57PM +0100, Julien Rouhaud wrote:
> Sorry, I just realized that I forgot to commit the last changes before sending
> the patch, so here's the correct v2.

Thanks for the patch.

> +	if (skipit)
> +	{
> +		ereport(NOTICE,
> +			 (errmsg("skipping invalid index \"%s.%s\"",
> +				 get_namespace_name(get_rel_namespace(indexOid)),
> +				 get_rel_name(indexOid))));

ReindexRelationConcurrently() issues a WARNING when bumping on an
invalid index, shouldn't the same log level be used?

Even with this patch, it is possible to reindex an invalid toast index
with REINDEX INDEX (with and without CONCURRENTLY), which is the
problem I mentioned upthread (Er, actually only for the non-concurrent
case as told about reindex_index).  Shouldn't both cases be prevented
as well with an ERROR?
--
Michael

--0F1p//8PRICkK4MW
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAl5XcHsACgkQnvQgOdby
QH3cIhAAilpjdskbXGn2ifgkPZMhBlDX6VVH4gMQWFusJhmLH9mj/Ku/MC0cvLoH
7Azt6hI0liK79qEU7qbsil9grDda9spYMWTgXuWmz+C63NktfD3oGknAmwlDmqWV
BABUxRzXPqmuS5H/rc1azliBazX0IexEZRAeYjcKWH8PagwGS90hw44KnpnkQaYW
coXqjOiLvW2+KC0pxmQOTkVev3v8mWCIB48ku/9rywVbWwqygWaL8g3hbY8Turmw
6UwaVEhnqOU4itT/xeyyBgO8YQ/H79+iO/5IC8hdefkkSsYOqhmA+NJAfqR30ekT
A6aYnsBuA2Hgo3ucfp0v8e9FiKHsL1o21LLv8J62fiRDq0IhGf/JsyqCDY9xEgIZ
OIQC5vd7ZgJ/nlFqWEIqZu0g3I3zi7Tl1DQPyIcDPddzZD7XDpO9I9veXSCsfHiW
M/e2COnURiCirGfs8jKPf1tZwfPb3AN8Sg/VU3K1r7TU5c3ZCno2AotVS2qGvGnY
WklQBJMQ+2Xd+WjFaB/OYo7lVJsWe5Z/M5oK6MJiW6o/pPJFvh3//aNOzFTexwLh
RW37T0gZfpRNuQmg4bciRhiCkvleT5L8Vo7TGHdfhLp82yBALtFRCK5GUmszCrOP
9VvRFEP1d8BH/yrvgtW48Nq6zcm7mafnTTYdQbKCuy6n7Oklt2I=
=M31b
-----END PGP SIGNATURE-----

--0F1p//8PRICkK4MW--