Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.92) (envelope-from ) id 1j7Lzj-0003Uv-NJ for pgsql-hackers@arkaria.postgresql.org; Thu, 27 Feb 2020 16:26:40 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1j7Lzi-0005IL-EV for pgsql-hackers@arkaria.postgresql.org; Thu, 27 Feb 2020 16:26:38 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1j7Lzh-0005IE-U0 for pgsql-hackers@lists.postgresql.org; Thu, 27 Feb 2020 16:26:38 +0000 Received: from mail-qk1-x741.google.com ([2607:f8b0:4864:20::741]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1j7Lza-0002pB-Rl for pgsql-hackers@lists.postgresql.org; Thu, 27 Feb 2020 16:26:36 +0000 Received: by mail-qk1-x741.google.com with SMTP id e16so3696604qkl.6 for ; Thu, 27 Feb 2020 08:26:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=2ndquadrant-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=JcPyx84qz9O7nrMTAaff7OUT6A1ezvoZ51CSHe1PkK8=; b=Eh7q+c4ox1DVkMyVVseKIAWu3/wV71QtdsaZ8C2vAfUojzQ+tCmH4u5G+fhNF1K8BD P3vm/65wBBtOittu1NriVY055oGtwsh1YB4mwubdd8uE5S8eOXFMfLVlNI0h/59ZtKx/ 3wFfXcoiPJXdGFXmPrxGUf6AMvEg1DSulwxhcjdO9EplUMXhgaZU8F+NMyFhi8vHHCVl OWQLS3hfHTTQF3PwJ5DyavZojHmYO85nO4gIC8hoX7fJFfK7+0NqdVMopwlLgPpIhxwY vex3Jm4+cmBIUba3R7ZZxA28Lx5oIIEgXwPfJdzWFnttzJ+vNqM9zJCRTqt4FbVcVxrW Pjcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=JcPyx84qz9O7nrMTAaff7OUT6A1ezvoZ51CSHe1PkK8=; b=UziE8i3QWyz2QZx3Vqz/8zqNomIueHzwIEk03xYEsdC6UpkLLsTY8nutvSAN0N4BWS YpEKsAaXY6HvQZFpM5xcElOaP4rmYKCB8bBTloAICHih6dxWwM/oqUwevW9DtwF0+mS7 Uvwdb2UmFJIwA3cCLeG8E8XGIYzEq4wfAJD67G+6InjdpfxmqCXdoos16gUbHwsXIkwj tVC53L6/xeYfv97x8bIxyHnq8IhiMnNisfqDZwWdnAXKRAkZRzI7owFWJced+oyb0zAT Ezir3BQd8DT7gTgzaE1i2kAMhpes0H/79bHB7XeN06aukZs3A6sZA6VifG3TaI+VwVV7 JB1Q== X-Gm-Message-State: APjAAAXFS98jTRUHu3ch30zw+MaQzsqYPrMlDOxhWCVo9mxFBMvjGOyt /RMBu/G/3m2LEwfKLukaIXDZRA== X-Google-Smtp-Source: APXvYqzOcYgjrP32Wn4/bRL9u2uHx6bf4qOyc/boqudWcqT0WkcY5zcocpIxL/Cl8VDCh2f7rPFAxg== X-Received: by 2002:a05:620a:2231:: with SMTP id n17mr1839qkh.264.1582820789757; Thu, 27 Feb 2020 08:26:29 -0800 (PST) Received: from nimloth.alvh.no-ip.org ([179.56.30.174]) by smtp.gmail.com with ESMTPSA id p14sm3466244qtk.50.2020.02.27.08.26.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Feb 2020 08:26:28 -0800 (PST) Received: by nimloth.alvh.no-ip.org (Postfix, from userid 1000) id A279630064B; Thu, 27 Feb 2020 13:26:26 -0300 (-03) Date: Thu, 27 Feb 2020 13:26:26 -0300 From: Alvaro Herrera To: Amit Langote Cc: Pg Hackers , Tom Lane Subject: Re: pg_trigger.tgparentid Message-ID: <20200227162626.GA1693@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Thanks both -- pushed. I also changed regress/sql/triggers to leave tables around that have a non-zero tgparentid. This ensures that the pg_upgrade test sees such objects, as well as findoidjoins. I refrained from doing the findoidjoins dance itself, though; I got a large number of false positives that I think are caused by some pg12-era hacking. -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services