Date: Fri, 28 Feb 2020 16:33:18 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Make mesage at end-of-recovery less scary.
Message-ID: <20200228073318.GD2688@paquier.xyz>
References: <20200228.160100.2210969269596489579.horikyota.ntt@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="gE7i1rD7pdK0Ng3j"
Content-Disposition: inline
In-Reply-To: <20200228.160100.2210969269596489579.horikyota.ntt@gmail.com>
Precedence: bulk


--gE7i1rD7pdK0Ng3j
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Feb 28, 2020 at 04:01:00PM +0900, Kyotaro Horiguchi wrote:
> Hello, this is a followup thread of [1].
>=20
> # I didn't noticed that the thread didn't cover -hackers..
>=20
> When recovery of any type ends, we see several kinds of error messages
> that says "WAL is broken".

Have you considered an error context here?  Your patch leads to a bit
of duplication with the message a bit down of what you are changing
where the end of local pg_wal is reached.

> +	* reached the end of WAL.  Otherwise something's really wrong and
> +	* we report just only the errormsg if any. If we don't receive

This sentence sounds strange to me.  Or you meant "Something is wrong,
so use errormsg as report if it is set"?

> +			 * Note: errormsg is alreay translated.

Typo here.

> +	if (StandbyMode)
> +		ereport(actual_emode,
> +			(errmsg ("rached end of WAL at %X/%X on timeline %u in %s during stre=
aming replication",

StandbyMode happens also with only WAL archiving, depending on if
primary_conninfo is set or not.

> +	(errmsg ("rached end of WAL at %X/%X on timeline %u in %s during crash =
recovery",

FWIW, you are introducing three times the same typo, in the same
word, in three different messages.
--
Michael

--gE7i1rD7pdK0Ng3j
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAl5Ywj4ACgkQnvQgOdby
QH04rQ//XZD8v9PZIPvmko2/kaF30P4x27SxL7pyMcBiQS+fEHdzFe0WZgknVebF
VzhJtrnAzIwUsJW0Ud5ZcWa31d1EQWYQSL5sf2qjTAsEnGEvQzVxxXsv/kaUFykd
TVCqV+r1VK7ct48lYQewQwkFzhQcFKauQzV7EyEsZjaJe/T6z2bkt3rUuk2z2CtF
d6XbCXWHylgEtIylWeZhDH2qmehQW5Vqc8RTwrYH/j1quYzQJtpJ9Xdnb7PGBLoh
MSygaiiyCLNQv2l/QEpWIuxQYqiEMx9klWEMLlaB1t/Ty7QkzYOn54/HS8ePZJI6
hHq95p1BOzd6uMOBHtaIDsz0FVOmjtR5bYBfMjXLwVIHE8wA/bMBai69fhHkCWLx
3J2NntvozIWyXu1+Nd669HYbZ9OSFuGbz7Zt2xAR7m9hjm6zQhaZks4V45O6w3hO
EQnfRDNE7nXw3EC8vum5A1oVNtS/lpqk0xNAt30SQKq8yGj/PdTM51e57V6LrMVV
ytmNj9z74UJbyChhjSWx7NfITzo1t8Jxyeqn5EBXmbe456OxXdw9vTOtL03FZmJH
RaTWEckyzznm66S1MmXRW6hz7cgAHuBVVcARHloqlReQU+yEPkgZV6hGz8SEg1E9
+9WANe4Nil5TPlZXFwLfSeWVqJB7afbuZefCNqQlJZpT45oIqCw=
=5iF9
-----END PGP SIGNATURE-----

--gE7i1rD7pdK0Ng3j--