Date: Sat, 29 Feb 2020 13:59:42 -0600
From: Justin Pryzby <pryzby@telsasoft.com>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Michael Paquier <michael@paquier.xyz>,
	Jeff Janes <jeff.janes@gmail.com>,
	pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: vacuum verbose detail logs are unclear; log at *start* of each
 stage
Message-ID: <20200229195942.GK29456@telsasoft.com>
References: <20191220171132.GB30414@telsasoft.com>
 <CAMkU=1xAyWnwnLGORBOD=pyv=ccEkDi=wKeyhwF=gtB7QxLBwQ@mail.gmail.com>
 <20200113004542.GA26045@telsasoft.com>
 <20200121134934.GY26045@telsasoft.com>
 <20200122053457.GG174860@paquier.xyz>
 <20200126053629.GO13621@telsasoft.com>
 <00cb953d-19e6-e4c3-f90b-f3f25556a407@2ndquadrant.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <00cb953d-19e6-e4c3-f90b-f3f25556a407@2ndquadrant.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Precedence: bulk

On Thu, Feb 27, 2020 at 10:10:57AM +0100, Peter Eisentraut wrote:
> On 2020-01-26 06:36, Justin Pryzby wrote:
> >Subject: [PATCH v3 1/4] Remove gettext erronously readded at 580ddce
> >
> >-	appendStringInfo(&buf, _("%s."), pg_rusage_show(&ru0));
> >+	appendStringInfo(&buf, "%s.", pg_rusage_show(&ru0));
> 
> Why do you think it was erroneously added?

I was wrong.

It seemed useless to me to translate "%s.", but I see now that at least JA.PO
uses a different terminator than ".".

$ git grep -C3 'msgid "%s."$' '*.po' |grep msgstr
src/backend/po/de.po-msgstr "%s."
src/backend/po/es.po-msgstr "%s."
src/backend/po/fr.po-msgstr "%s."
src/backend/po/id.po-msgstr "%s."
src/backend/po/it.po-msgstr "%s."
src/backend/po/ja.po-msgstr "%s。"

BTW I only *happened* to see your message on the www interface.  I didn't get
the original message.  And the "Resend email" button didn't get it to me,
either..

-- 
Justin