Date: Tue, 3 Mar 2020 22:59:11 +0100
From: Tomas Vondra <tomas.vondra@2ndquadrant.com>
To: Dilip Kumar <dilipbalaut@gmail.com>
Cc: Amit Kapila <amit.kapila16@gmail.com>,
	Michael Paquier <michael@paquier.xyz>,
	Peter Eisentraut <peter.eisentraut@2ndquadrant.com>,
	PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: PATCH: logical_work_mem and logical streaming of large
 in-progress transactions
Message-ID: <20200303215911.sxlyi6nsbs2lzwhm@development>
References: 
 <CAFiTN-snMb=53oqkM8av8Lqfxojjm4OBwCNxmFssgLCceY_zgg@mail.gmail.com>
 <CAA4eK1KbvOAiUnQQxtXAXSQAAroU9h0msp6KXrysYOEVHb34vA@mail.gmail.com>
 <CAFiTN-uJM0m8Nj__+ZRj+_t06NZKyk117v15HsErL4sshXkT9Q@mail.gmail.com>
 <CAA4eK1KXf1ACLpAxQv6oFj_L9JEFjdJpPstuduD7b4zXPMsD5g@mail.gmail.com>
 <CAFiTN-uNKhtscqUvHokdxykM8w4J5aLEgSx+_Xx2O-sBdfc=tA@mail.gmail.com>
 <CAA4eK1LT2UArE9FyPqZcmV2kALhEmcXnZGdreYWCdCJ9vRUd8Q@mail.gmail.com>
 <CAFiTN-t1YNmoBf7k1kUrUue4q1Tf3GXjGwZTseNLivKmr9sz1Q@mail.gmail.com>
 <CAFiTN-vR7jQBP75FpvE=-4Ca-3jqsJA55ZDct0B8UtE0x13gCQ@mail.gmail.com>
 <CAFiTN-uNzEyY3YL1EZabWcG=Bah1nO8hno+-UaAkCDcfCGYC0g@mail.gmail.com>
 <20200303214646.6adway2z5wnapjem@development>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="dus7xrj6qe3zbayp"
Content-Disposition: inline
In-Reply-To: <20200303214646.6adway2z5wnapjem@development>
Precedence: bulk


--dus7xrj6qe3zbayp
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline

D'oh! As usual I forgot to actually attach the patch I mentioned. So
here it is ...

regards

-- 
Tomas Vondra                  http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

--dus7xrj6qe3zbayp
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="xid-assignment-v12-fix.patch"

--- a/src/backend/access/transam/xlog.c
+++ b/src/backend/access/transam/xlog.c
@@ -7574,6 +7574,19 @@ StartupXLOG(void)
                    LWLockRelease(XidGenLock);
                }
+               /*
+                * Assign subtransaction xids to the top level xid if the
+                * record has that information. This is required at most
+                * once per subtransactions.
+                */
+               if (TransactionIdIsValid(xlogreader->toplevel_xid) &&
+                   standbyState >= STANDBY_INITIALIZED)
+               {
+                   Assert(XLogStandbyInfoActive());
+                   ProcArrayApplyXidAssignment(xlogreader->toplevel_xid,
+                                               1, &record->xl_xid);
+               }
+
                /*
                 * Before replaying this record, check if this record causes
                 * the current timeline to change. The record is already

--dus7xrj6qe3zbayp--