Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.92) (envelope-from ) id 1j9LAE-0002qM-DR for pgsql-hackers@arkaria.postgresql.org; Wed, 04 Mar 2020 03:57:42 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1j9LAC-0008E5-4f for pgsql-hackers@arkaria.postgresql.org; Wed, 04 Mar 2020 03:57:40 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1j9LAB-0008Dx-Rc for pgsql-hackers@lists.postgresql.org; Wed, 04 Mar 2020 03:57:39 +0000 Received: from mx0a-00296801.pphosted.com ([148.163.150.38]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j9LA2-00009Y-DA for pgsql-hackers@postgresql.org; Wed, 04 Mar 2020 03:57:38 +0000 Received: from pps.filterd (m0114583.ppops.net [127.0.0.1]) by mx0a-00296801.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 0243rwqG032669 for ; Wed, 4 Mar 2020 03:57:26 GMT Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by mx0a-00296801.pphosted.com with ESMTP id 2yhwjrgdwa-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Wed, 04 Mar 2020 03:57:26 +0000 Received: by mail-pf1-f199.google.com with SMTP id s19so604727pfh.10 for ; Tue, 03 Mar 2020 19:57:26 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=AvBaxCi4MzAHFPfgKoZuTxhxtDWb9O9XUSEVIfdlU4g=; b=qFHyIxJMboYqtz8ibG+rsA7mgll3tyKHNM4aIZcvawHaFtW0rJtAfbZaiypfvwL142 5hRZjOihewreT8/dtN/WIrewrd7GGx1vyuETdAATJBIQhgLaqDCtWMF8g9GSQrIKY2Bx yto2+Au7jNzZhUOvUEwVmuQvt3nzMeeS2mQoAEh5o50ehlPfXDIEA43XGV3Cy8acBWHW TyRPZ8u+6qi8bHdq8JsW0IB5/t9Tc1icQQuE0izpL+zlRAkHU8Q3kET6vTXRrnTWUbJg J0ANLbigqM6v9dxOgeX8rzG1pbcGO469Ykm/zL1JK7rzPx2eJzgHnEK9KSYh6o5r2UdZ b9Pg== X-Gm-Message-State: ANhLgQ3EKfueTUfICXGB+fCsDNHLYaETlRZTZ3M1MkMMX/JkhPtQkdI9 B84V+LjPazXZLKtPTgJtiOeUpk0mvmhixmZF8DHBOH37hDF6e4REsHY+nHpmqCwBo0KBUKnBowV RTz5++p+o36wlPn16jGpSbjp1KA854RgG/t7b2wxFidYHcKPhMg== X-Received: by 2002:a17:902:401:: with SMTP id 1mr1178031ple.177.1583294245948; Tue, 03 Mar 2020 19:57:25 -0800 (PST) X-Google-Smtp-Source: ADFU+vtRt8fkP0H2/xdh7Hi5/I97efV5A5xOrO8cP0X06OpCsvAioQ7T4A2hub/LqCZJ46+W9bDWQw== X-Received: by 2002:a17:902:401:: with SMTP id 1mr1178018ple.177.1583294245683; Tue, 03 Mar 2020 19:57:25 -0800 (PST) Received: from localhost (li1619-9.members.linode.com. [172.104.39.9]) by smtp.gmail.com with ESMTPSA id w84sm14555053pfc.95.2020.03.03.19.57.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Mar 2020 19:57:25 -0800 (PST) Date: Wed, 4 Mar 2020 11:57:19 +0800 From: Adam Lee To: Jeff Davis Cc: pgsql-hackers@postgresql.org, Peter Geoghegan , Heikki Linnakangas Subject: Re: Add LogicalTapeSetExtend() to logtape.c Message-ID: <20200304035719.GB1022@earth.local> References: <20200228061641.GA883@earth.local> <619e61919fd604c2caa629536ee87615b732e054.camel@j-davis.com> <20200303014935.GA1022@earth.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138,18.0.572 definitions=2020-03-03_08:2020-03-03,2020-03-03 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 malwarescore=0 spamscore=0 impostorscore=0 priorityscore=1501 adultscore=0 clxscore=1015 lowpriorityscore=0 bulkscore=0 phishscore=0 mlxlogscore=248 suspectscore=1 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2001150001 definitions=main-2003040025 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On Tue, Mar 03, 2020 at 08:46:24AM -0800, Jeff Davis wrote: > On Tue, 2020-03-03 at 09:49 +0800, Adam Lee wrote: > > Master: 12729ms 12970ms 12999ms > > With my patch(a pointer): 12965ms 13273ms 13116ms > > With your patch(flexible array): 12906ms 12991ms 13043ms > > Hmm.. looks like you didn't reproduce the difference I saw. What > compiler/version? It was "Apple clang version 11.0.0 (clang-1100.0.33.17)". Then I changed to "gcc-9 (Homebrew GCC 9.2.0_3) 9.2.0" this morning. Master(e537aed61d): 13342.844 ms 13195.982 ms 13271.023 ms With my patch(a pointer): 13020.029 ms 13008.158 ms 13063.658 ms With your patch(flexible array): 12870.117 ms 12814.725 ms 13119.255 ms -- Adam Lee