Date: Thu, 5 Mar 2020 12:02:40 -0300
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Pg Hackers <pgsql-hackers@lists.postgresql.org>,
	Paul Jungwirth <pj@illuminatedcomputing.com>
Subject: Re: useless RangeIOData->typiofunc
Message-ID: <20200305150240.GA8064@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <462.1583418414@sss.pgh.pa.us>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

On 2020-Mar-05, Tom Lane wrote:

> Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> > Thanks -- ISTM it makes more sense to put the FmgrInfo before the
> > typioparam too:
> 
> > typedef struct RangeIOData
> > {
> >     TypeCacheEntry *typcache;    /* range type's typcache entry */
> >     FmgrInfo    proc;            /* element type's I/O function */
> >     Oid         typioparam;      /* element type's I/O parameter */
> > } RangeIOData;
> 
> Yeah, WFM.  Maybe even rename the FmgrInfo to "typioproc"
> or the like?

Good idea, thanks!  Pushed with that change.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services