Date: Thu, 5 Mar 2020 23:09:06 -0300
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Alexey Kondratov <a.kondratov@postgrespro.ru>,
	Alexander Korotkov <a.korotkov@postgrespro.ru>,
	Liudmila Mantrova <l.mantrova@postgrespro.ru>,
	Thomas Munro <thomas.munro@gmail.com>,
	Andrey Borodin <x4mmm@yandex-team.ru>,
	David Steele <david@pgmasters.net>,
	Andres Freund <andres@anarazel.de>,
	PostgreSQL-development <pgsql-hackers@postgresql.org>,
	Dmitry Dolgov <9erthalion6@gmail.com>, vladimirlesk@yandex-team.ru,
	dsarafan@yandex-team.ru
Subject: Re: [Patch] pg_rewind: options to use restore_command from
 recovery.conf or command line
Message-ID: <20200306020906.GA11931@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20200306012120.GD52814@paquier.xyz>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

On 2020-Mar-06, Michael Paquier wrote:

> I was also thinking to split the patch into two pieces:
> - Introduction of common/archive.c and common/fe_archive.c (the former
> is used by xlogarchive.c and the latter only by pg_rewind).  The
> latter is dead code without the second patch, but this would validate
> the MSVC build with the buildfarm.
> - The pg_rewind pieces with the new option.

Hmm, doesn't the CF bot already validate the MSVC build?

Splitting in two seems all right, but I think one commit that introduces
dead code is not great.  It may make more sense to have one commit for
common/archive.c, and a second commit that does fe_archive plus
pg_rewind changes ...  If that doesn't work for whatever reason, then
doing a single commit may be preferrable.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services