Date: Mon, 9 Mar 2020 13:07:07 -0300
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Remove utils/acl.h from catalog/objectaddress.h
Message-ID: <20200309160707.GA3597@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <7601e258-26b2-8481-36d0-dc9dca6f28f1@2ndquadrant.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

On 2020-Mar-07, Peter Eisentraut wrote:

> I noticed that catalog/objectaddress.h includes utils/acl.h for no apparent
> reason.  It turns out this used to be needed but not anymore. So removed it
> and cleaned up the fallout.  Patch attached.

parser/parse_nodes.h already includes nodes/parsenodes.h, so the seeming
redundancy in places such as 

> diff --git a/src/include/commands/vacuum.h b/src/include/commands/vacuum.h
> index c27d255d8d..be63e043c6 100644
> --- a/src/include/commands/vacuum.h
> +++ b/src/include/commands/vacuum.h
> @@ -19,6 +19,7 @@
>  #include "catalog/pg_statistic.h"
>  #include "catalog/pg_type.h"
>  #include "nodes/parsenodes.h"
> +#include "parser/parse_node.h"

(and others) is not just apparent; it's also redundant in practice.  And
it's not like parse_node.h is ever going to be able not to depend on
parsenodes.h, so I would vote to remove nodes/parsenodes.h from the
headers where you're adding parser/parse_node.h.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services