Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.92) (envelope-from ) id 1jBjI6-0008Cw-7p for pgsql-hackers@arkaria.postgresql.org; Tue, 10 Mar 2020 18:07:42 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1jBjI5-00037Y-1y for pgsql-hackers@arkaria.postgresql.org; Tue, 10 Mar 2020 18:07:41 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1jBjI4-00036o-Kc for pgsql-hackers@lists.postgresql.org; Tue, 10 Mar 2020 18:07:40 +0000 Received: from mail-qk1-x741.google.com ([2607:f8b0:4864:20::741]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1jBjI1-0001lA-Ul for pgsql-hackers@postgresql.org; Tue, 10 Mar 2020 18:07:40 +0000 Received: by mail-qk1-x741.google.com with SMTP id u25so13671989qkk.3 for ; Tue, 10 Mar 2020 11:07:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=2ndquadrant-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=why+UYNSEA6/BufeDMQs25jcfWy9YtnBccb7lYIyYXk=; b=stb+BZqjHWDS8KnvOfp5L9FKiUM/nPQwSQdmPpJns1kAgaj+s088/kQsVcMc3TiZPA rfcD2skijKKDp5BMM2nvjHarF9ekeHt6msJQBT9pzNQmneQVbRGxsJmn+LHR985WlQl6 6O3I17v3u+mwPu4WETBTn1KCPRFExe6TwQdJyz1vI5l0zWTo4KHh86OnDV8GAGQiX0/U FHZPn9/wMzFFlWV0xznjXvr9d5aEtto3yy9iE938TyDvuJ8N4cMWQ+V/jcujfkfT7Ehh r7deSUe99mMp6IPAMOEAOEvOHKrorHztfv4E9VLU2ziX+WmyQAPL9tHXbK1VIPTzcrR/ KWZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=why+UYNSEA6/BufeDMQs25jcfWy9YtnBccb7lYIyYXk=; b=HXN/BFQPVBGCmxwvJaum9GqQm89c1fO7/QGcpBoj7Tkqophcqv4Eqw9cwcp8VFOUKJ pxR4ZDbFcK3Z6PFcoeAUzrBHfZo1sLMse+qf4AsS4ZpQ7TrVBqlaX8msSePFRjVAJjTG lnadQtrrCgKfly9P2EN0/gh5IZx1FqdiDfc/efhyGTH4aJQNxui8ttx5PRf5vyRZaFfz q07angh9vAy3qCiZiUC9viz+T6pj7AMF8Xopio/5dJ4Iq74hpLBsiRkiZWwJH3ekArE7 TnumVEsNTNKEusCznXAtv1jodPPwnNYbib/zfnSrYi8kYPvN6JVa1j/WhA27pNsj/37s ccEA== X-Gm-Message-State: ANhLgQ3JCpJzDjpKqkRnArFn4iP3Jb0ZgqzE6yoEv8gnsKFbGsbbyH98 QvpY7afWLUuruC7WawLL0PuLIw== X-Google-Smtp-Source: ADFU+vtnoLIefTgYcXIrHJTfMjx//ToDibw8JkY16wNvnLastgVg3VWd8deaC9dEtYVwztvYmESu8g== X-Received: by 2002:a37:b9c7:: with SMTP id j190mr5388301qkf.21.1583863655915; Tue, 10 Mar 2020 11:07:35 -0700 (PDT) Received: from nimloth.alvh.no-ip.org ([190.121.31.1]) by smtp.gmail.com with ESMTPSA id h47sm5794551qtb.75.2020.03.10.11.07.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Mar 2020 11:07:35 -0700 (PDT) Received: by nimloth.alvh.no-ip.org (Postfix, from userid 1000) id 79B3D300945; Tue, 10 Mar 2020 15:07:31 -0300 (-03) Date: Tue, 10 Mar 2020 15:07:31 -0300 From: Alvaro Herrera To: Peter Eisentraut Cc: pgsql-hackers Subject: Re: backend type in log_line_prefix? Message-ID: <20200310180731.GA15183@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk I like these patches; the first two are nice cleanup. My only gripe is that pgstat_get_backend_desc() is not really a pgstat function; I think it should have a different name with a prototype in miscadmin.h (next to the enum's new location, which I would put someplace near the "pmod.h" comment rather than where you put it; perhaps just above the AuxProcType definition), and implementation probably in miscinit.c. -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services