Date: Fri, 13 Mar 2020 16:09:31 -0300
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: James Coleman <jtc331@gmail.com>
Cc: Tomas Vondra <tomas.vondra@2ndquadrant.com>,
	Michael Paquier <michael@paquier.xyz>,
	Rafia Sabih <rafia.pghackers@gmail.com>,
	Peter Geoghegan <pg@bowt.ie>, Simon Riggs <simon@2ndquadrant.com>,
	Shaun Thomas <shaun.thomas@2ndquadrant.com>,
	Dmitry Dolgov <9erthalion6@gmail.com>,
	Alexander Korotkov <a.korotkov@postgrespro.ru>,
	Tom Lane <tgl@sss.pgh.pa.us>,
	PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Subject: Re: [PATCH] Incremental sort (was: PoC: Partial sort)
Message-ID: <20200313190931.GA11508@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: 
 <CAAaqYe9rkqSA2OAYQAg=Kdv1v1j6WoB9wLX5MkT_w27z_upKkQ@mail.gmail.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

On 2020-Mar-13, James Coleman wrote:

> > I don't propose to commit 0003 of course, since it's not our policy;
> > that's just to allow running pgindent sanely, which gives you 0004
> > (though my local pgindent has an unrelated fix).  And after that you
> > notice the issue that 0005 fixes.
> 
> Is there a page on how you're supposed to run pgindent/when stuff like
> this does get added/etc.? It's all a big mystery to me right now.
> 
> Also, I noticed some of the pgindent changes aren't for changes in
> this patch series; I have that as a separate patch, but not attached
> because I see that running pgindent locally generates a massive patch,
> so I'm assuming we just ignore those for now?

Ah, I should have paid more attention to what I was attaching.  Yeah,
ideally you run pgindent and then only include the changes that are
relevant to your patch series.  We run pgindent across the whole tree
once every release, so about yearly.  Some commits go in that are not
indented correctly, and those bother everyone -- I'm guilty of this
myself more frequently than I'd like.

You can specify a filelist to pgindent, also.  What I do is super
low-tech: do a "git diff origin/master", copy the filelist, and then
^V^E to paste that list into a command line to run pgindent (editing to
remove the change histogram and irrelevant files).  I should automate
this ...

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services