Date: Mon, 16 Mar 2020 21:14:36 -0300
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Mark Dilger <mark.dilger@enterprisedb.com>
Cc: "pgsql-hackers@postgresql.org" <pgsql-hackers@lists.postgresql.org>,
	Kohei KaiGai <kaigai@heterodb.com>,
	Adam Brightwell <adam.brightwell@crunchydata.com>
Subject: Re: Adding missing object access hook invocations
Message-ID: <20200317001436.GA17904@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <435CD295-F409-44E0-91EC-DF32C7AFCD76@enterprisedb.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

On 2020-Mar-16, Mark Dilger wrote:

> Hackers,
> 
> While working on object access hooks, I noticed several locations where I would expect the hook to be invoked, but no actual invocation.  I think this just barely qualifies as a bug.  It's debatable because whether it is a bug depends on the user's expectations and whether not invoking the hook in these cases is defensible.  Does anybody have any recollection of an intentional choice not to invoke in these locations?

Hmm, possibly the create-time calls are missing.

I'm surprised about the InvokeObjectDropHook calls though.  Doesn't
deleteOneObject already call that?  If we have more calls elsewhere,
maybe they are redundant.  I think we should only have those for
"shared" objects.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services