Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.92) (envelope-from ) id 1jEExc-0006AK-78 for pgsql-hackers@arkaria.postgresql.org; Tue, 17 Mar 2020 16:20:56 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1jEExa-0006Vz-4I for pgsql-hackers@arkaria.postgresql.org; Tue, 17 Mar 2020 16:20:54 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1jEExZ-0006Vs-RB for pgsql-hackers@lists.postgresql.org; Tue, 17 Mar 2020 16:20:53 +0000 Received: from mail-qt1-x82e.google.com ([2607:f8b0:4864:20::82e]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1jEExW-0008Ba-7p for pgsql-hackers@postgresql.org; Tue, 17 Mar 2020 16:20:53 +0000 Received: by mail-qt1-x82e.google.com with SMTP id d22so17971279qtn.0 for ; Tue, 17 Mar 2020 09:20:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telsasoft-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=RjUsLMLhbJnkGzOhEePIb+CPwkzwmAKQzQVPW+FpudE=; b=qGizKEE7BW8yiGFPDlBJ2o4A5FcXn25SA0jNoTYeR3h7pdox4ILD/TP6wfMzIEanu0 gTd/qke5e8ooPmYykp60n59Tp7doB/C6yALRXMVWmQIAI+/ATkE1vjodn2ZwW2qXN1CW 6NklIVUaBWEmv4WxxGHJK96h4rwBsGtZm82fSC6N9Eq3SOr/QYr4CkBSXll0eL0g+ebR Q/HDc5aV+H3OKnCOfCBLfUJp2KTmzWX9kD6GZokynn0kFR/bA/t1YS7XtXaie14IJmOj R6CNqkn4y5kMhMLuiPHtFDSs9biADwJysYHky7t2VzUeG4DsuWstzeSDnDoqtei9syrX /EeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=RjUsLMLhbJnkGzOhEePIb+CPwkzwmAKQzQVPW+FpudE=; b=b+6S/kSop1XDzJxQZWRSXe4cczwjaoqoedwUf2cpC3JUVBwvsdXaFhCHk6ye4cf/5v IJkKUsk3stjazDHOcsia23OHWSXbovLHhJBbz0hKoAou4D27aHjGJtKLT/fL9pl4XqCk QVyMzNucIMpejsjKGssgvUgArKqzHjrp1+VlMeXImg68MdyaMcV6GgUi9kdyoO97nvxg U+T1ErrTr1jz5eS4Yz4/JB9OEJHHgx6pl5DO4XnhstMxGM/LwKlKwJquk/CyveFAu5Tr dfLpfUUkcDP4ouTn0jerJVMIHk3INM2Z9TSLpsbv4z8NmIspzfgIUphMofcuMLRYYYoN Ji6w== X-Gm-Message-State: ANhLgQ0CpHNf0wRv7PR04Quzqkr5EDb6Jlw5aifMkg3qUhaNSNiSKEDc Rga3kiL8wbybKXu4YECfkHSiwA== X-Google-Smtp-Source: ADFU+vvMKr5AhRDaEQURkzAOGjaUFBC5ZC675wSQ2R0T+aGq0aMgkZ7RvNvFjycQw+Igh4izsePbXw== X-Received: by 2002:ac8:4404:: with SMTP id j4mr5865761qtn.95.1584462047659; Tue, 17 Mar 2020 09:20:47 -0700 (PDT) Received: from pryzbyj (charmander.telsasoft.com. [50.244.222.1]) by smtp.gmail.com with ESMTPSA id u77sm2201412qka.134.2020.03.17.09.20.46 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 17 Mar 2020 09:20:46 -0700 (PDT) Received: by pryzbyj (Postfix, from userid 1000) id 170F5800CF1; Tue, 17 Mar 2020 11:20:45 -0500 (CDT) Date: Tue, 17 Mar 2020 11:20:44 -0500 From: Justin Pryzby To: Michael Paquier Cc: Alvaro Herrera , Amit Langote , Tom Lane , pgsql-hackers@postgresql.org Subject: Re: ALTER tbl rewrite loses CLUSTER ON index Message-ID: <20200317162044.GX26184@telsasoft.com> References: <20200316132731.GJ26184@telsasoft.com> <20200316142523.GA14606@alvherre.pgsql> <20200317053332.GE2206@paquier.xyz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200317053332.GE2206@paquier.xyz> User-Agent: Mutt/1.9.4 (2018-02-28) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On Tue, Mar 17, 2020 at 02:33:32PM +0900, Michael Paquier wrote: > > Yeah, in cluster(), mark_index_clustered(). > > Patch 0002 from Justin does that, I would keep this refactoring as > HEAD-only material though, and I don't spot any other code paths in > need of patching. > > The commit message of patch 0001 is not what you wanted I guess. That's what git-am does, and I didn't find any option to make it less unreadable. I guess I should just delete the email body it inserts. | The commit message is formed by the title taken from the "Subject: ", a | blank line and the body of the message up to where the patch begins. Excess | whitespace at the end of each line is automatically stripped. -- Justin