Date: Tue, 17 Mar 2020 18:43:51 +0100
From: Julien Rouhaud <rjuju123@gmail.com>
To: Christoph Berg <myon@debian.org>,
	Peter Eisentraut <peter.eisentraut@2ndquadrant.com>,
	Michael Paquier <michael@paquier.xyz>,
	Thomas Munro <thomas.munro@gmail.com>,
	Robert Haas <robertmhaas@gmail.com>,
	Laurenz Albe <laurenz.albe@cybertec.at>,
	Douglas Doole <dougdoole@gmail.com>,
	Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Collation versioning
Message-ID: <20200317174351.GB63950@nol>
References: 
 <CA+hUKGLEJwpEfPbX7P=ujQnBwduo6eaN+UuJu+zQTHN+VWruqA@mail.gmail.com>
 <20200311084427.GA12358@nol>
 <20200312140026.GA1689@nol>
 <20200316075738.GE2331@paquier.xyz>
 <20200316140520.GA21497@nol>
 <20200317063749.GF2206@paquier.xyz>
 <20200317071928.psjiklzvkgqpl3dd@nol>
 <20200317104234.GA89737@nol>
 <fd8d4475-85ad-506f-2dda-f4d6e66785bc@2ndquadrant.com>
 <20200317163147.GA1337480@msg.df7cb.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200317163147.GA1337480@msg.df7cb.de>
Precedence: bulk

On Tue, Mar 17, 2020 at 05:31:47PM +0100, Christoph Berg wrote:
> Re: Peter Eisentraut 2020-03-17 <fd8d4475-85ad-506f-2dda-f4d6e66785bc@2ndquadrant.com>
> > Did we discuss the regcollation type?  In the current patch set, it's only
> > used in two places in a new regression test, where it can easily be replaced
> > by a join.  Do we need it?


I originally wrote it for a previous version of the patchset, to shorten the
pg_dump query, but that went out when I replaced the DDL command with native
functions instead.  It didn't seem to hurt to keep it, so I relied on it in the
regression tests.


> > I realize we've been adding new reg* types lately; I'm not sure what the
> > current idea is on that.
>
> Not sure if that's the case there, but reg* typecasts are very handy
> when used interactively in ad-hoc queries.


+1.  I'm obviously biased, but I find it quite useful when querying pg_depend,
which may become more frequent once we start generating warnings about possibly
corrupted indexes.