Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.92) (envelope-from ) id 1jEJix-0006ME-18 for pgsql-hackers@arkaria.postgresql.org; Tue, 17 Mar 2020 21:26:07 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1jEJiv-0001Zk-5Y for pgsql-hackers@arkaria.postgresql.org; Tue, 17 Mar 2020 21:26:05 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1jEJfj-0003Xp-W1 for pgsql-hackers@lists.postgresql.org; Tue, 17 Mar 2020 21:22:48 +0000 Received: from mail-qk1-x742.google.com ([2607:f8b0:4864:20::742]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1jEJfh-0006sP-57 for pgsql-hackers@postgresql.org; Tue, 17 Mar 2020 21:22:46 +0000 Received: by mail-qk1-x742.google.com with SMTP id u25so35261988qkk.3 for ; Tue, 17 Mar 2020 14:22:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=2ndquadrant-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=8gsCMPyaXeROFW8nP5DEGkDEN3tlP1+BNGAP26MZ4x4=; b=yjytIEsALH9MOt0VrfVeTC+h35YAaqg2UWmw2Bo97So0KKKslbW3NLocZQnSePV2RC Ggo1rN6/wnYqFx7CUhpVOfcvcxX9YmpKT6qSE53XvzVw+6JeizokyWgG5bXoKfZTPghA GsMc/2lFx/VgKpTHI1mQ/ahS7/VkKGKKsQvx9zWebGOemnNVPrSmTbR1w02zerB2y2Q6 oAWtxWZsXUitmC5QVeyA34/t9or4ljWK2TnA2lABqU1M1cth5znKXSDfMApIFaIcCaFg MkVgda8+TbTFl6rXGwXpCwLmbkjUYpX0yHeMJQh+KxduTrWZyM8SVyhTv4fGhdocXeqo AM6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=8gsCMPyaXeROFW8nP5DEGkDEN3tlP1+BNGAP26MZ4x4=; b=jAg7nTsX0dxAquP7KnLiCllpmQq8zCQZKMpfFmgLtZcwhPU2xjaEFPi3xTHV+b3vHI 5qlYSXSoKM58ZMBTB8dJRRMgSiGIRrFxisko1g6JpNkrGm6k7Y65ROfNvX4HfMJ1kRG+ kYKy387AMTKPxSybXg0XZthYilEjhG78oZ4XVCulXrgQB04t17tc/S+Jun1TULbPNzaV y5KBNJ06SFYkcmu5mfP2taWznd63/Uwk5F8I/iJ6EvsVxdrXqZvwK/AQoibloiFuiKU7 QODtBZjGW7oQMr0mNHyBokB10eHJrofS9CiIKXM8NwUbarVcHNrbgeYu29jk7Ih/QC2n tqng== X-Gm-Message-State: ANhLgQ1yNLRt9+f079OvKxX1aCf8KeJduVp0Dxb9xi21WBbKcbgEBL0l OtA66Shvp9DbBTqRuiMfC9gNsQ== X-Google-Smtp-Source: ADFU+vv3Ci0H8Pg+OfDbYJThVOyeAcv69HC5GH9fYk/Jr7C8sZVf7OfTHT7i134rI2otoE2WlPVeTQ== X-Received: by 2002:a05:620a:645:: with SMTP id a5mr892799qka.493.1584480164064; Tue, 17 Mar 2020 14:22:44 -0700 (PDT) Received: from nimloth.alvh.no-ip.org ([179.56.96.77]) by smtp.gmail.com with ESMTPSA id f16sm3216230qtk.61.2020.03.17.14.22.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Mar 2020 14:22:43 -0700 (PDT) Received: by nimloth.alvh.no-ip.org (Postfix, from userid 1000) id 204683007EA; Tue, 17 Mar 2020 18:22:41 -0300 (-03) Date: Tue, 17 Mar 2020 18:22:41 -0300 From: Alvaro Herrera To: Antonin Houska Cc: Michael Paquier , Thomas Munro , Robert Haas , "pgsql-hackers@postgresql.org" Subject: Re: Attempt to consolidate reading of XLOG page Message-ID: <20200317212241.GA16426@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <88183.1574261429@antos> User-Agent: Mutt/1.10.1 (2018-07-13) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 2019-Nov-20, Antonin Houska wrote: > Alvaro Herrera wrote: > > What is logical_read_local_xlog_page all about? Seems useless. Let's > > get rid of it. > > It seems so. Should I post a patch for that? No need .. it was simple enough. Just pushed it. Thanks -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services