Date: Wed, 18 Mar 2020 09:17:20 -0500
From: Justin Pryzby <pryzby@telsasoft.com>
To: Mike Palmiotto <mike.palmiotto@crunchydata.com>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>,
	Michael Paquier <michael@paquier.xyz>,
	Andres Freund <andres@anarazel.de>,
	Yuli Khodorkovskiy <yuli.khodorkovskiy@crunchydata.com>,
	Tom Lane <tgl@sss.pgh.pa.us>, pgsql-hackers@postgresql.org
Subject: Re: Auxiliary Processes and MyAuxProc
Message-ID: <20200318141720.GH26184@telsasoft.com>
References: <20200317215218.GC26184@telsasoft.com>
 <20200318010433.GA17520@alvherre.pgsql>
 <CAMN686GixjieQhS9DtRvvAX9q73Px25yWuyWZRWeHh81ZE4XvA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: 
 <CAMN686GixjieQhS9DtRvvAX9q73Px25yWuyWZRWeHh81ZE4XvA@mail.gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Precedence: bulk

On Wed, Mar 18, 2020 at 09:22:58AM -0400, Mike Palmiotto wrote:
> On Tue, Mar 17, 2020 at 9:04 PM Alvaro Herrera <alvherre@2ndquadrant.com> wrote:
> >
> > On 2020-Mar-17, Justin Pryzby wrote:
> >
> > > +static PgSubprocess process_types[] = {
> > > +     {
> > > +             .desc = "checker",
> > > +             .entrypoint = CheckerModeMain
> > > +     },
> > > +     {
> > > +             .desc = "bootstrap",
> > > +             .entrypoint = BootstrapModeMain
> > > +     },
> >
> > Maybe this stuff can be resolved using a technique like rmgrlist.h or
> > cmdtaglist.h.  That way it's not in two separate files.
> 
> Great suggestion, thanks! I'll try this out in the next version.

Also, I saw this was failing tests both before and after my rebase.

http://cfbot.cputube.org/
https://ci.appveyor.com/project/postgresql-cfbot/postgresql/builds/31535161
https://ci.appveyor.com/project/postgresql-cfbot/postgresql/builds/31386446

-- 
Justin