Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.92) (envelope-from ) id 1jEeIV-0005by-W6 for pgsql-hackers@arkaria.postgresql.org; Wed, 18 Mar 2020 19:24:12 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1jEeIT-0002SI-Po for pgsql-hackers@arkaria.postgresql.org; Wed, 18 Mar 2020 19:24:09 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1jEeIT-0002SB-Ef for pgsql-hackers@lists.postgresql.org; Wed, 18 Mar 2020 19:24:09 +0000 Received: from mail-lj1-x230.google.com ([2a00:1450:4864:20::230]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1jEeIR-0004zG-5B for pgsql-hackers@postgresql.org; Wed, 18 Mar 2020 19:24:09 +0000 Received: by mail-lj1-x230.google.com with SMTP id a2so2854184ljk.6 for ; Wed, 18 Mar 2020 12:24:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=L4goW4npoyynUyvOvCayodbz49AC8dVNBlo05xuvcJA=; b=vCR4hs+Xpf8kry3SJhc+cMO501xdMBVLVgc36IvK74/euQIqlMiCny9iXetRSnS0/C JcIDDr+E0wyPCacRwWfK51ID+PuhzbzdIuAPAGNzUFb2ZnaL/e5Pp37rLX4o4QZPiWG7 AiwA+glvH13BbY5ipJIkEk/KCy4VRVHPKnXOej0YE2/kntRuWNV4oSOcXxsQjdaLZmIv XlkJew61VkwetCSAhxaLzYcDoFBHQTPHUrjAhEEvdJCDWNlFNyjF8ROswsOnpU/1XADl iMM9bAmdgfA08ptGlCDoYZiVtM7Vg+rKD86U7oe+HguWE/FZevhlU3R6wzLDCA/dchlm 680w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=L4goW4npoyynUyvOvCayodbz49AC8dVNBlo05xuvcJA=; b=b6sR/3UkI35PgerFIDP4T9DausEUiduvCeFXdcrKPDFQwf9H3AyTunu91+fZARX+u2 gSLKgeIdO448NVE0Qwj5svFVmpTYAhRP5kl87tHP9I0ZCm1jV3iMu5O1IRAFzwBLMrx7 W5+iAxUr8XLnx1ElLtFK47ZHkTfOufznOT42IO9J2+ljrr8ska7m3FJRXb+UUehs8dwq ew8Flxx7yWPQGPerxLmuAVt0t9GcwtdcMHrwCrToB9uyi8u3ALIciMYy8mC0KvquqeiF zpqyFPrvyrD26uXOENdrU2EyKtZIN3uiSwaMyUh2oVivU8wSpfS6TGnrqDMVCtOe1EmC WeLQ== X-Gm-Message-State: ANhLgQ2nfg00VX86KHWcgqwHmsmRsQo3FQ05CFs0PWIV1V+UGfIGgGkI i7auhzJYo0prskfPHlu1KP0= X-Google-Smtp-Source: ADFU+vucUZmLB3t7jFFSo5pCaUjG6Udkxv/RKZsDHeTQ+Pu/eWJEnaeq2xrzeFF2HY2hnZnarUbVeQ== X-Received: by 2002:a05:651c:234:: with SMTP id z20mr3207821ljn.187.1584559446140; Wed, 18 Mar 2020 12:24:06 -0700 (PDT) Received: from nol (82-64-124-11.subs.proxad.net. [82.64.124.11]) by smtp.gmail.com with ESMTPSA id y20sm4895614ljd.35.2020.03.18.12.24.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Mar 2020 12:24:05 -0700 (PDT) Date: Wed, 18 Mar 2020 20:24:00 +0100 From: Julien Rouhaud To: Kirill Bychik Cc: PostgreSQL Hackers , Thomas Munro Subject: Re: WAL usage calculation patch Message-ID: <20200318192400.GB69354@nol> References: <20200317153136.GA63950@nol> <20200317203222.GA44781@nol> <20200318171916.GA69354@nol> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On Wed, Mar 18, 2020 at 08:48:17PM +0300, Kirill Bychik wrote: > > I'm attaching a v5 with fp records only for temp tables, so there's no risk of > > instability. As I previously said I'm fine with your two patches, so unless > > you have objections on the fpi test for temp tables or the documentation > > changes, I believe those should be ready for committer. > > No objections on my side either. Thank you for your review, time and efforts! Great, thanks also for the patches and efforts! I'll mark the entry as RFC.