Date: Fri, 20 Mar 2020 09:53:59 -0500
From: Justin Pryzby <pryzby@telsasoft.com>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: Masahiko Sawada <masahiko.sawada@2ndquadrant.com>,
	Alvaro Herrera <alvherre@2ndquadrant.com>,
	Andres Freund <andres@anarazel.de>,
	Michael Paquier <michael@paquier.xyz>, pgsql-hackers@postgresql.org
Subject: Re: error context for vacuum to include block number
Message-ID: <20200320145359.GY26184@telsasoft.com>
References: 
 <CAA4eK1Ki-Bkd4hWncbL7VT5zp_mm=_Q=TbzFeQvPprZy0j44Dw@mail.gmail.com>
 <CAA4eK1K5BTuni+Ykv9sPCU40Fc7vgfWmBXXwFOYzDeExugvpJg@mail.gmail.com>
 <CAA4eK1KuP+fznRUJ_x_hcbWzPLS-vCJfZn9wjxWK-+TO1Luzbg@mail.gmail.com>
 <20200319040758.GP26184@telsasoft.com>
 <CAA4eK1LwDGPmAvtOmmHvDTp-KHvcKCW7u36sFKdHjrWJaSVE2w@mail.gmail.com>
 <20200319202931.GT26184@telsasoft.com>
 <20200320002909.GU26184@telsasoft.com>
 <CAA4eK1L_FWiqqBfpm_C8b8bw95EykonbcLWzFFQAC6ucgudZFQ@mail.gmail.com>
 <20200320065120.GW26184@telsasoft.com>
 <CAA4eK1+TQi4qanvLCOdcMbRKb=nCsJkWPhDi+KmOnkOyi79_Sw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: 
 <CAA4eK1+TQi4qanvLCOdcMbRKb=nCsJkWPhDi+KmOnkOyi79_Sw@mail.gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Precedence: bulk

On Fri, Mar 20, 2020 at 04:58:08PM +0530, Amit Kapila wrote:
> See, how the attached looks?  I have written a commit message as well,
> see if I have missed anyone is from the credit list?

Thanks for looking again.

Couple tweaks:

+/* Phases of vacuum during which an error can occur. */

Can you say: "during which we report error context"
Otherwise it sounds like we've somehow precluded errors from happening anywhere
else, which I don't think we can claim.

In the commit messsage:
|The additional information displayed will be block number for errors
|occurred while processing heap and index name for errors occurred
|while processing the index.

=> error occurring

|This will help us in diagnosing the problems that occurred during a
|vacuum.  For ex. due to corruption if we get some error while vacuuming,

=> problems that occur

Maybe it should say that this will help both 1) admins who have corruption due
to hardware (say); and, 2) developer's with corruption due to a bug.

-- 
Justin