Date: Mon, 23 Mar 2020 23:16:16 -0500
From: Justin Pryzby <pryzby@telsasoft.com>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: Masahiko Sawada <masahiko.sawada@2ndquadrant.com>,
	Alvaro Herrera <alvherre@2ndquadrant.com>,
	Andres Freund <andres@anarazel.de>,
	Michael Paquier <michael@paquier.xyz>, pgsql-hackers@postgresql.org
Subject: Re: error context for vacuum to include block number
Message-ID: <20200324041616.GA21443@telsasoft.com>
References: <20200319202931.GT26184@telsasoft.com>
 <20200320002909.GU26184@telsasoft.com>
 <CAA4eK1L_FWiqqBfpm_C8b8bw95EykonbcLWzFFQAC6ucgudZFQ@mail.gmail.com>
 <20200320065120.GW26184@telsasoft.com>
 <CAA4eK1+TQi4qanvLCOdcMbRKb=nCsJkWPhDi+KmOnkOyi79_Sw@mail.gmail.com>
 <20200320145359.GY26184@telsasoft.com>
 <CAA4eK1+iuT4gqiqYVdLkOggjA9q5v+dVxT_G3dOyHVokn+YjBg@mail.gmail.com>
 <CA+fd4k6jdiEW_+sPEMWS2TmSnE-ddAdFDSQu9WpXJsK6c2=+-Q@mail.gmail.com>
 <20200323081639.GI2563@telsasoft.com>
 <CAA4eK1KaWto3+4+EsLPRFL6HKs8=_42V2ivAFEPBU-o_o6AYXw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: 
 <CAA4eK1KaWto3+4+EsLPRFL6HKs8=_42V2ivAFEPBU-o_o6AYXw@mail.gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Precedence: bulk

On Mon, Mar 23, 2020 at 02:25:14PM +0530, Amit Kapila wrote:
> > Yea, and it would be misleading if we reported "while scanning block..of
> > relation" if we actually failed while writing its FSM.
> >
> > My previous patches did this:
> >
> > +               case VACUUM_ERRCB_PHASE_VACUUM_FSM:
> > +                       errcontext("while vacuuming free space map of relation \"%s.%s\"",
> > +                                       cbarg->relnamespace, cbarg->relname);
> > +                       break;
> >
> 
> In what kind of errors will this help?

If there's an I/O error on an _fsm file, for one.

-- 
Justin