Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.92) (envelope-from ) id 1jGrZy-0003Ja-Vf for pgsql-hackers@arkaria.postgresql.org; Tue, 24 Mar 2020 21:59:23 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1jGrZx-0005YG-Rh for pgsql-hackers@arkaria.postgresql.org; Tue, 24 Mar 2020 21:59:21 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1jGrZx-0005Vq-El for pgsql-hackers@lists.postgresql.org; Tue, 24 Mar 2020 21:59:21 +0000 Received: from mail-qk1-x744.google.com ([2607:f8b0:4864:20::744]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1jGrZu-0000Os-KA for pgsql-hackers@postgresql.org; Tue, 24 Mar 2020 21:59:21 +0000 Received: by mail-qk1-x744.google.com with SMTP id q188so278084qke.8 for ; Tue, 24 Mar 2020 14:59:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=2ndquadrant-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=Vv4OUiswOaKvPxZHK9X1NFVjIXAYkiGsvYA397k1lOQ=; b=E84fsuLVyz76uLYHHHsNcoEWgLTTIvIx3j7Qc1/CzAxK92fbrpSvst01TLNqqVAa2J aBezhhQj1HiF+Ap6oOhOafgE9K0OavXKg8lBfzHXsjymPNKCmiblJ3uOzgN3UqK9tWKH 1icU9AHbQXkFVNLL0uvxLdiHLvZ4JDI7F3dzJEA+Gdne8wF7EP/8oU9MZA9b09nYZlCH rTCyK+svWHQBAoDrXhby5jKmPkTwqinh2Rg8ZyS0PEbZZP4lRhwVugTVFfHA+gzYRKF7 d2vlbhtP4PfBziOGcfbz7bAZuIegEcs3fPdIxAxC8URd2tr8Y7B18rRUTbxRjvzLRYqP 6rjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=Vv4OUiswOaKvPxZHK9X1NFVjIXAYkiGsvYA397k1lOQ=; b=ovG2hKhOZvhp6isG8w7UkGGZgOi84QqpGuf9FADFCb9WLVo6a+8Z3obixovRzCd1U5 ZvQUvtjgxIFknYXo1eMgipn0jIeX5y1jg0mt2IC2XJYjoAL9B/22IdK+DmDfIWwEfLfE YQEs2SGIR5i0RXcbr5emG0AKoaQOk+pmLFAfI2KVU3YcXmde9uU+p19CmAXeKjwbgFEg O10nReoN8U91EvTHQqR2z/WMUnv+COndbLJW0C3wOUbSYbXk10QhwPfx/f1KifceS2me AUUfhwGbJCCiaWRfQCru3wbRzDUfSIzWGt1k2LHxAHrqdixJWUFqqlQZVSBmQK2Jl3Ki r3xg== X-Gm-Message-State: ANhLgQ2ekWavKpeXlJ7qFJC1S/WNxuXLKTdNOdJkrhcs82mst8pHxIni X8/SR2mMoDjIme/lEH6ro+ve1w== X-Google-Smtp-Source: ADFU+vuNT36Wn3A2BH7guMih2DNhvCstD18Ut1ffThUGh9N3bhN32wJV4WxixTkGgKYhCsT1P54vvg== X-Received: by 2002:a37:4bd3:: with SMTP id y202mr53238qka.32.1585087156118; Tue, 24 Mar 2020 14:59:16 -0700 (PDT) Received: from nimloth.alvh.no-ip.org ([193.37.252.100]) by smtp.gmail.com with ESMTPSA id l13sm15397680qtu.66.2020.03.24.14.59.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Mar 2020 14:59:15 -0700 (PDT) Received: by nimloth.alvh.no-ip.org (Postfix, from userid 1000) id A2C1A300825; Tue, 24 Mar 2020 18:49:22 -0300 (-03) Date: Tue, 24 Mar 2020 18:49:22 -0300 From: Alvaro Herrera To: Sergei Kornilov Cc: Michael Paquier , Tomas Vondra , Kyotaro Horiguchi , "andres@anarazel.de" , "david@pgmasters.net" , "pgsql-hackers@postgresql.org" , Peter Eisentraut Subject: Re: allow online change primary_conninfo Message-ID: <20200324214922.GA27503@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <3315711584471826@sas1-d3a1bf2bd2e7.qloud-c.yandex.net> User-Agent: Mutt/1.10.1 (2018-07-13) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk I think the startup sighup handler should be in startup.c, not xlog.c, which has enough random code already. We can add an accessor in xlog.c to let changing the walrcv status flag, to be called from the signal handler. -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services