Date: Fri, 27 Mar 2020 17:44:07 -0400
From: Stephen Frost <sfrost@snowman.net>
To: Andres Freund <andres@anarazel.de>
Cc: Robert Haas <robertmhaas@gmail.com>,
	Amit Kapila <amit.kapila16@gmail.com>,
	Suraj Kharage <suraj.kharage@enterprisedb.com>,
	tushar <tushar.ahuja@enterprisedb.com>,
	Rajkumar Raghuwanshi <rajkumar.raghuwanshi@enterprisedb.com>,
	Rushabh Lathia <rushabh.lathia@gmail.com>,
	Tels <nospam-pg-abuse@bloodgate.com>,
	David Steele <david@pgmasters.net>,
	Andrew Dunstan <andrew.dunstan@2ndquadrant.com>,
	PostgreSQL Hackers <pgsql-hackers@postgresql.org>,
	Jeevan Chalke <jeevan.chalke@enterprisedb.com>,
	vignesh C <vignesh21@gmail.com>
Subject: Re: backup manifests
Message-ID: <20200327214407.GL13712@tamriel.snowman.net>
References: 
 <CA+TgmoYguaj65+cq=HPcZAXwu7PQJz6PAUe7Qg9PaKY_g6ca9w@mail.gmail.com>
 <CAF1DzPUhOBdZaV+R9UCuknHEVO=K=FGc4diXGxUxdf=dJy6biA@mail.gmail.com>
 <CAF1DzPWTXp04c_=BOyNbJ_v9ccXrwjeNBc6_cQxkgdphQvpVXA@mail.gmail.com>
 <CA+TgmobhNAHF1jqi9swroOqZgkcaGXNZG_bm8bdtHEJV=fmF3w@mail.gmail.com>
 <CAA4eK1K0bRCeds25pw_Wt+AG-vOoEL+6_8pjKaq3g2QthNmiag@mail.gmail.com>
 <CAA4eK1+WyCVLZ03ZPH+POAY_NE80p+QxXDUnF10iryHj3vFjTA@mail.gmail.com>
 <CA+TgmoZBrwYvfQ=ymXk669+hgdQxpoypQVYdWiGwpOE_yuMW4A@mail.gmail.com>
 <20200327062927.2ijbvoa7pqoc3w7b@alap3.anarazel.de>
 <CA+TgmoZBhohTrORC3jUFXB8K1BJh6ojxmXdLp8WKWsX165DwWQ@mail.gmail.com>
 <20200327203225.hcm6ag4grwsiruea@alap3.anarazel.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="RS1722//baS0C3Tp"
Content-Disposition: inline
In-Reply-To: <20200327203225.hcm6ag4grwsiruea@alap3.anarazel.de>
User-Agent: Mutt/1.5.24 (2015-08-30)
Precedence: bulk


--RS1722//baS0C3Tp
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Greetings,

* Andres Freund (andres@anarazel.de) wrote:
> On 2020-03-27 15:20:27 -0400, Robert Haas wrote:
> > On Fri, Mar 27, 2020 at 2:29 AM Andres Freund <andres@anarazel.de> wrot=
e:
> > > Hm. Should this warn if the directory's permissions are set too openly
> > > (world writable?)?
> >=20
> > I don't think so, but it's pretty clear that different people have
> > different ideas about what the scope of this tool ought to be, even in
> > this first version.
>=20
> Yea. I don't have a strong opinion on this specific issue. I was mostly
> wondering because I've repeatedly seen people restore backups with world
> readable properties, and with that it's obviously possible for somebody
> else to change the contents after the checksum was computed.

For my 2c, at least, I don't think we need to check the directory
permissions, but I wouldn't object to including a warning if they're set
such that PG won't start.  I suppose +0 for "warn if they are such that
PG won't start".

Thanks,

Stephen

--RS1722//baS0C3Tp
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCgAGBQJefnOnAAoJEO1sijiDR2RVdXYP/3OhTvwxuyC2Z21myNtSKGD8
uoB7J3Mp3dostnnVTGbTTHOAbqdmHlE2Pxrob99jz2/yz1wWTeIU9BdRawWPnSvL
TsyLfnccsEisV8icY09aASzczaH58zARffVlHsDL2yk56JCTXpvUf1/I9wMdN554
HbWkbYR1CWakYUxeqU7tDfrTcJOfZcKMoLOBYXat8khre0Q/3wrO/8p/EiQ32cyz
2Ta3KE993hXvt5QqDU68AjFKj7qTguDfsgPCa2PTwnIrsXf3aE7DekGXwiVGl+RG
k/fzYDtYG9TAUI2mm2rb8jkXmAy9rrAJMVeo82GktsLyt9BiA/cdr24zO2lvx8tQ
j27N4NpEuartpnwrYOJ84LqaF+yh8J7sUBAWSMp5ca2OnQ8uMaxY1wYPtkCDjW7g
Z2CaGqr5kt/uzLZ+a8ybCa4/owtB8xUg98wBxcbgGCFkQkCRYaWqLmNDb4/Qob8y
npXeVp7psck5kGtIXbatChQrEWWP7+1sCG0v1ELsYcH7zwzhRwiHNoeZWLBPLqUZ
MrartqQBzkhPfX7UYuX9VR3QBwPEEtshh5/frbFNzSnO3EOTZx71DXfu5bY3o+4x
mbvyVAwVzJ5gzb6c1uryJKjA6Db1EIYSnueEo1P1+VKlFCWO5dfqyaKmkARu1D7c
r6Q/6QSLZP0GPhMXewm4
=LWq+
-----END PGP SIGNATURE-----

--RS1722//baS0C3Tp--