Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jJc1Z-0002ZW-2w for pgsql-hackers@arkaria.postgresql.org; Wed, 01 Apr 2020 11:59:13 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1jJc1X-0007lX-Uf for pgsql-hackers@arkaria.postgresql.org; Wed, 01 Apr 2020 11:59:11 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jJc1X-0007lQ-Nj for pgsql-hackers@lists.postgresql.org; Wed, 01 Apr 2020 11:59:11 +0000 Received: from mail-qv1-xf43.google.com ([2607:f8b0:4864:20::f43]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1jJc1V-0004Cs-MI for pgsql-hackers@postgresql.org; Wed, 01 Apr 2020 11:59:10 +0000 Received: by mail-qv1-xf43.google.com with SMTP id s18so8172128qvn.1 for ; Wed, 01 Apr 2020 04:59:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telsasoft-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=EhS1OC/Ul0xrPhMmMbhqDFG0GH8E2x2HTz7Gyo+yO4U=; b=nonNKyy5tWdFNOIzYwQ+ksCFCdvAwmLa+XG+8vCm4CY2Y/l6RQz1xW1tK5htVwTZId 2K8vGq0SsazhdLrKvaa2cqLcI0Gtuybuc54DvhXBe48+te/fZkCZBZh3/CusAEuzER0N I8m4r4+SwkGODj4Bgzfz4lJs3Niewih9RgC/ejjqpFGlaJCu3GwBJUxjMyAEU4OnJZBy SZL8KdoWchL6rBX8odaFQlOoPFLi0FG7jRCLtY6gp2JDK6qQyt2XcgnpCaWLZmWZSPvt xY5hhLLXty6BJYNZeTKxN3f5eoQS/TUp8BddjQEAi2/k2bWQXVrPoBk3daj3faHrHKK3 xvNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=EhS1OC/Ul0xrPhMmMbhqDFG0GH8E2x2HTz7Gyo+yO4U=; b=unOZB4rOXeLDTCR4Z2rtXaGw6lQwE2ylpTEHBB0xeYiaUkG+0MwYy5jgNTeZvuu1IJ kkXOevjKBXBgMGtKbYxdgMGzasEpdg5MqMl00m3LqnpHd9NP3yvbjvD2KmRxbm2nnhYL PDCQyZLB2WsW708gTWQw+W6YGqxXZ9jrSOcdqnwcalytwJZVU8oE4WKz12h1RxYb1mcB Zy/fua5sxDHxrNPD1/0TQV6SJhDP36cpXJ33Dyz72ixnHobgSFLdt5D3e0Fg0TAOz+Gb r5vzrtlFVH+xm95DUaMmGQXkNn/ZYLNa0gUqFODfOZJwWn5VBIUzsKTMMeMUe3U2QKDm Th+w== X-Gm-Message-State: ANhLgQ0zfdXh1oKIh6LlgBk/PHReNvqNpK5LTUc5TObKkCVXX4x3O5OW 4w3mjnbi/YyYbq08UYGn10kSCg== X-Google-Smtp-Source: ADFU+vt+FytLX5vhdQzMPukgLJEmd4J/F/AlSD+IztsDbyF6snCqTGikrRuVhZ4sNakc0zujVFBEVg== X-Received: by 2002:a0c:e94a:: with SMTP id n10mr20570296qvo.12.1585742348846; Wed, 01 Apr 2020 04:59:08 -0700 (PDT) Received: from pryzbyj (charmander.telsasoft.com. [50.244.222.1]) by smtp.gmail.com with ESMTPSA id d72sm1232813qkg.102.2020.04.01.04.59.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 01 Apr 2020 04:59:07 -0700 (PDT) Received: by pryzbyj (Postfix, from userid 1000) id 6E5148006BB; Wed, 1 Apr 2020 06:59:06 -0500 (CDT) Date: Wed, 1 Apr 2020 06:59:06 -0500 From: Justin Pryzby To: Alexander Korotkov Cc: Nikita Glukhov , Nikolay Shaplov , Oleg Bartunov , pgsql-hackers Subject: Re: [PATCH] Opclass parameters Message-ID: <20200401115906.GR14618@telsasoft.com> References: <20190910220358.6tj37k4v6vyaqac7@development> <0807f67b-c1bd-3760-7fc5-89900ae65408@postgrespro.ru> <20190912001634.oeteg5edzke47om4@development> <5e95f74b-977f-ce98-cd73-302a0fb83e9f@postgrespro.ru> <683fc323-e483-c972-e6bf-d03994a8df67@postgrespro.ru> <20200331024419.GB14618@telsasoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On Wed, Apr 01, 2020 at 02:53:41PM +0300, Alexander Korotkov wrote: > On Tue, Mar 31, 2020 at 12:15 PM Alexander Korotkov > wrote: > > What is XXX supposed to be? > > > > The rest of patch looks good to me. > > I've pushed the patch excepts XXX. Thank you. > You're welcome to clarify XXX and/or do additional corrections. XXX was a reminder to myself to check the accuracy of that description, rather than just its language. As you can see, I didn't manage to do that, but the language is at least consistent. Thanks for pushing the update. -- Justin