Date: Mon, 6 Apr 2020 22:11:45 +0200
From: Tomas Vondra <tomas.vondra@2ndquadrant.com>
To: James Coleman <jtc331@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Alvaro Herrera <alvherre@2ndquadrant.com>,
	Michael Paquier <michael@paquier.xyz>,
	Rafia Sabih <rafia.pghackers@gmail.com>,
	Peter Geoghegan <pg@bowt.ie>, Simon Riggs <simon@2ndquadrant.com>,
	Shaun Thomas <shaun.thomas@2ndquadrant.com>,
	Dmitry Dolgov <9erthalion6@gmail.com>,
	Alexander Korotkov <a.korotkov@postgrespro.ru>,
	PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>,
	Andreas Karlsson <andreas@proxel.se>
Subject: Re: [PATCH] Incremental sort (was: PoC: Partial sort)
Message-ID: <20200406201145.ig56cdzrkt4u5mou@development>
References: 
 <CAAaqYe953TA0Pj+08jEBgK_=5zMCJO-vgYnh4n_Me71ZdzDJLg@mail.gmail.com>
 <20200401214215.ut6b72e3zlbm33w2@development>
 <CAAaqYe8fWa8pBUStzW-4JocF+d3pFBVLFmb9rtcD0m12NskBJw@mail.gmail.com>
 <20200402024746.5wlwk6q7eiv5faux@development>
 <CAAaqYe90h3F5NbgtNJAMrXAiGZwML8=_E_qs4MCyYtqea+5Hhg@mail.gmail.com>
 <20200403002028.kp3rxncmwvsui6xz@development>
 <CAAaqYe--jV9pHrX5NRw9R2QGG+nRuPPKguzHhKZwhp6XPOiyuQ@mail.gmail.com>
 <CAAaqYe9XO7ZKrpVkrz2e0ja=eeFCX0Wqpmc7r23R84JU9uCLxQ@mail.gmail.com>
 <20200405130110.2bdxaz4ed5jx2eae@development>
 <20200406195722.teiha6foiy3lix3s@development>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
In-Reply-To: <20200406195722.teiha6foiy3lix3s@development>
Precedence: bulk

On Mon, Apr 06, 2020 at 09:57:22PM +0200, Tomas Vondra wrote:
>Hi,
>
>I've pushed the fist part of this patch series - I've reorganized it a
>bit by moving the add_partial_path changes to the end. That way I've
>been able to add regression test demonstrating impact of the change on
>plans involving incremental sort nodes (which wouldn't be possible when
>committing the add_partial_path first). I'll wait a bit before pushing
>the two additional parts, so that if something fails we know which bit
>caused it.
>

Hmmm, I see the buildfarm is not happy about it - a couple of animals
failed, but some succeeded. The failure seems like a simple difference
in explain output, but it's not clear why would it happen (and I've
ran the tests many times but never seen this failure).

Investigating.

-- 
Tomas Vondra                  http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services