Date: Thu, 9 Apr 2020 22:01:51 -0500
From: Justin Pryzby <pryzby@telsasoft.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: doc review for v13
Message-ID: <20200410030150.GZ2228@telsasoft.com>
References: <20200408165653.GF2228@telsasoft.com>
 <20200410022746.GT1606@paquier.xyz>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="xYeFQzU4VZLrHqxU"
Content-Disposition: inline
In-Reply-To: <20200410022746.GT1606@paquier.xyz>
User-Agent: Mutt/1.9.4 (2018-02-28)
Precedence: bulk


--xYeFQzU4VZLrHqxU
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Apr 10, 2020 at 11:27:46AM +0900, Michael Paquier wrote:
> On Wed, Apr 08, 2020 at 11:56:53AM -0500, Justin Pryzby wrote:
> > I previously mailed separately about a few individual patches, some of which
> > have separate, ongoing discussion and aren't included here (incr sort, parallel
> > vacuum).
> 
> I have gone through your changes, and committed what looked like the
> most obvious mistakes in my view.  Please see below for more
> comments.

Thanks - rebased for cfbot and continued review.

>  required pages to remove both downlink and rightlink are already  locked.  That
> -evades potential right to left page locking order, which could deadlock with
> +avoid potential right to left page locking order, which could deadlock with
> Not sure which one is better, but the new change is grammatically
> incorrect.

Thanks for noticing

"Evades" usually means to act to avoid detection by the government.  Like tax
evasion.

>        <varname>auto_explain.log_settings</varname> controls whether information
> -      about modified configuration options are printed when execution plan is logged.
> -      Only options affecting query planning with value different from the built-in
> +      about modified configuration options is printed when an execution plan is logged.
> +      Only those options which affect query planning and whose value differs from its built-in
> Depends on how you read the sentence, but here is seemt to me that 
> "statistics" is the correct subject, no?

Statistics ?

>      <literal>_tz</literal> suffix. These functions have been implemented to
> -    support comparison of date/time values that involves implicit
> +    support comparison of date/time values that involve implicit
> The subject is "comparison" here, no?

You're right.

-- 
Justin

--xYeFQzU4VZLrHqxU
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment;
 filename="v2-0001-doc-psql-opclass-opfamily.patch"