Date: Fri, 10 Apr 2020 08:46:44 -0500
From: Justin Pryzby <pryzby@telsasoft.com>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: Masahiko Sawada <masahiko.sawada@2ndquadrant.com>,
	Mahendra Singh Thalor <mahi6run@gmail.com>,
	Dilip Kumar <dilipbalaut@gmail.com>, Sergei Kornilov <sk@zsrv.org>,
	pgsql-hackers@postgresql.org
Subject: Re: doc review for parallel vacuum
Message-ID: <20200410134644.GB2228@telsasoft.com>
References: <20200322021801.GB2563@telsasoft.com>
 <CAA4eK1Jwqq2=pukH212AvyWv6_oOJxM2YAypOEzR1KgeJj8_BQ@mail.gmail.com>
 <CAA4eK1+V5QovVH49=9RhsrshoNAA+TZBVGrv30xAqG0ncPUQaQ@mail.gmail.com>
 <20200407045551.GI2228@telsasoft.com>
 <CA+fd4k74vmiU=KdEjLJU4UQ99UvLn0mp-CKTkiF=bUdyk2PUNA@mail.gmail.com>
 <CAA4eK1JwUXkV4T2uAiLDYHT3efqkX2gE+Z5Z8g-DgCw377LN_g@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: 
 <CAA4eK1JwUXkV4T2uAiLDYHT3efqkX2gE+Z5Z8g-DgCw377LN_g@mail.gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Precedence: bulk

On Fri, Apr 10, 2020 at 12:56:08PM +0530, Amit Kapila wrote:
> On Wed, Apr 8, 2020 at 12:49 PM Masahiko Sawada
> <masahiko.sawada@2ndquadrant.com> wrote:
> >
> > On Tue, 7 Apr 2020 at 13:55, Justin Pryzby <pryzby@telsasoft.com> wrote:
> > >
> >
> > I don't have comments on your change other than the comments Amit
> > already sent. Thank you for reviewing this part!
> >
> 
> I have made the modifications as per my comments.  What do you think
> about the attached?

Couple more changes (in bold):

-     The <option>PARALLEL</option> option is used only for vacuum PURPOSES.
-     Even if this option is specified with THE <option>ANALYZE</option> option

Also, this part still doesn't read well:

-        * amvacuumcleanup to the DSM segment if it's the first time to get it?
-        * from them? because they? allocate it locally and it's possible that an
-        * index will be vacuumed by the different vacuum process at the next

If you change "it" and "them" and "it" and say "*a* different", then it'll be
ok.

-- 
Justin