Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jNuU5-00071V-6F for pgsql-hackers@arkaria.postgresql.org; Mon, 13 Apr 2020 08:30:25 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1jNuU4-0001kg-2a for pgsql-hackers@arkaria.postgresql.org; Mon, 13 Apr 2020 08:30:24 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jNuU3-0001kZ-Oo for pgsql-hackers@lists.postgresql.org; Mon, 13 Apr 2020 08:30:23 +0000 Received: from mail-qt1-x82c.google.com ([2607:f8b0:4864:20::82c]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1jNuTz-0003Mf-Mk for pgsql-hackers@postgresql.org; Mon, 13 Apr 2020 08:30:22 +0000 Received: by mail-qt1-x82c.google.com with SMTP id x2so6583654qtr.0 for ; Mon, 13 Apr 2020 01:30:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telsasoft-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=htRcf1+Ri9hzRytPKQRvtUhA1Yim5K9JCYE5S41dfFA=; b=1YzhXhvAwrve6Dm0zp1awogTMdjZH2iYNx/Jc4tvXNj7xXD6zxDHmZAhAa+9MunoD6 MdlCollZhsFIaMTbh50UKsIPVgR9PJVLGKqD+gHAqvX7lKe9opW64EEVH7X52Dz9nvTo hJVhVnONxMQ46OsvrbDXqsTmT1MlyYEqANVoe4fjv0+sZhuohDXyszJb/GAM917+ZpBi e/ceYMP89qK4THmh5fXkM9ppJyt+GpUs+9iuY2CE2LsM2JOATg6aFLbmdoWf9fSULi1e uX0KXulIAWrvn8YgFdreDJDpkmLMfe9ehy4yYMTNnXdqcw5V5OPQsEKCEfdv5lW/9mMk IZmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=htRcf1+Ri9hzRytPKQRvtUhA1Yim5K9JCYE5S41dfFA=; b=Szauo5yk/u3y7rZI7ysvLecr31pbsUhVzdZHmeb8Jj51xq1FBdZULvRgmvcv7JymCN HEDu/rEclfSWfXyZvRctTmc8PFNbxOo7lGsRCsg5nDj25IoDM9oIkdqHnYIZPW+S9ZZm uXnUEanIbViPIbzMzXMh6hgnKx4tCPgUMg/wWToOvK/TzGnX0+tTcUreNBgESz+EBzTC Kyu6+NXhnkLfIZ++26I2JkF4BgZ7h1Ca4lY3Q5ioRs4BRbXFh9NBcWjWdxGQudr87qSt Ue+0cHUY2j1qOCMKr3jvqaBVcfYAqoffXeMj8A5syohcNuP8fhwSgkBODGZced5yb5bU DDBw== X-Gm-Message-State: AGi0PuZDReb1s+lb28aWjfyi93g8bBXzz1iGKgiZQffnUpQZI+PoeetW wAUVkn5abMHWUAHyfomXjbCQSw== X-Google-Smtp-Source: APiQypJMQAg7J5rOtEUd39NcUOXFfjK1uI/i5fY/ovcn9BmvauErfARma42OPRKxw0jTJaoOobJRKA== X-Received: by 2002:ac8:4e01:: with SMTP id c1mr10314860qtw.170.1586766617733; Mon, 13 Apr 2020 01:30:17 -0700 (PDT) Received: from pryzbyj (charmander.telsasoft.com. [50.244.222.1]) by smtp.gmail.com with ESMTPSA id o201sm7205814qke.31.2020.04.13.01.30.16 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 13 Apr 2020 01:30:16 -0700 (PDT) Received: by pryzbyj (Postfix, from userid 1000) id 2FC47800A81; Mon, 13 Apr 2020 03:30:15 -0500 (CDT) Date: Mon, 13 Apr 2020 03:30:15 -0500 From: Justin Pryzby To: Amit Kapila Cc: Masahiko Sawada , Mahendra Singh Thalor , Dilip Kumar , Sergei Kornilov , pgsql-hackers Subject: Re: doc review for parallel vacuum Message-ID: <20200413083015.GQ2228@telsasoft.com> References: <20200322021801.GB2563@telsasoft.com> <20200407045551.GI2228@telsasoft.com> <20200410134644.GB2228@telsasoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On Mon, Apr 13, 2020 at 10:44:42AM +0530, Amit Kapila wrote: > On Fri, Apr 10, 2020 at 7:16 PM Justin Pryzby wrote: > > > > Also, this part still doesn't read well: > > > > - * amvacuumcleanup to the DSM segment if it's the first time to get it? > > - * from them? because they? allocate it locally and it's possible that an > > - * index will be vacuumed by the different vacuum process at the next > > > > If you change "it" and "them" and "it" and say "*a* different", then it'll be > > ok. > > > > I am not sure if I follow how exactly you want to change it but still > let me know what you think about if we change it like: "Copy the index > bulk-deletion result returned from ambulkdelete and amvacuumcleanup to > the DSM segment if it's the first time because they allocate locally > and it's possible that an index will be vacuumed by the different > vacuum process at the next time." I changed "the" to "a" and removed "at": |Copy the index |bulk-deletion result returned from ambulkdelete and amvacuumcleanup to |the DSM segment if it's the first time [???] because they allocate locally |and it's possible that an index will be vacuumed by a different |vacuum process the next time." Is it correct to say: "..if it's the first iteration" and "different process on the next iteration" ? Or "cycle" ? -- Justin