Date: Mon, 20 Apr 2020 00:02:15 -0700
From: Noah Misch <noah@leadboat.com>
To: Fujii Masao <masao.fujii@oss.nttdata.com>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>,
	Tom Lane <tgl@sss.pgh.pa.us>, pgsql-hackers@postgresql.org
Subject: Re: 001_rep_changes.pl stalls
Message-ID: <20200420070215.GA1395671@rfd.leadboat.com>
References: <20200406063649.GA3738151@rfd.leadboat.com>
 <20200414013849.GA886648@rfd.leadboat.com>
 <8807.1586828716@sss.pgh.pa.us>
 <20200417054146.GA1061007@rfd.leadboat.com>
 <fba5fc85-205a-3aeb-9bf6-a124f762aa27@oss.nttdata.com>
 <20200418070142.GA1075445@rfd.leadboat.com>
 <dcdb33ba-4bcc-d41e-4aad-23207e195ccf@oss.nttdata.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <dcdb33ba-4bcc-d41e-4aad-23207e195ccf@oss.nttdata.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Precedence: bulk

On Mon, Apr 20, 2020 at 02:30:08PM +0900, Fujii Masao wrote:
> +		 * Block if we have unsent data.  XXX For logical replication, let
> +		 * WalSndWaitForWal(), handle any other blocking; idle receivers need
> +		 * its additional actions.  For physical replication, also block if
> +		 * caught up; its send_data does not block.
> 
> It might be better to s/WalSndWaitForWal()/send_data()? Because not only
> WalSndWaitForWal() but also WalSndWriteData() seems to handle the blocking.
> WalSndWriteData() is called also under send_data, i.e., XLogSendLogical().

Thanks for reviewing.  WalSndWriteData() blocks when we have unsent data,
which is the same cause for blocking in WalSndLoop().  Since the comment you
quote says we let WalSndWaitForWal() "handle any other blocking", I don't
think your proposed change makes it more correct.  Also, if someone wants to
refactor this, the place to look is WalSndWaitForWal(), not any other part of
send_data().